You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/20 17:18:04 UTC

[GitHub] [thrift] Jens-G commented on pull request #2238: THRIFT-4942: Add getters setters, improves on #1859

Jens-G commented on pull request #2238:
URL: https://github.com/apache/thrift/pull/2238#issuecomment-695812257


   My idea was that you could add an option to the php generator that controls the new way using getters/setters and private fields, and if not set it would just generate the same code as before. Sorry for being not clear enough.
   
   If I get it right, what you do here is to add the getters/setters but leave the fields publicly accessible? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org