You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 15:24:26 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #8389: ARROW-8296: [C++][Dataset] Add IpcFileWriteOptions

bkietz commented on a change in pull request #8389:
URL: https://github.com/apache/arrow/pull/8389#discussion_r502506462



##########
File path: cpp/src/arrow/dataset/file_ipc.cc
##########
@@ -185,7 +185,13 @@ Result<std::shared_ptr<FileWriter>> IpcFileFormat::MakeWriter(
 
   auto ipc_options = checked_pointer_cast<IpcFileWriteOptions>(options);
 
-  ARROW_ASSIGN_OR_RAISE(auto writer, ipc::MakeFileWriter(destination, schema));
+  // override use_threads to avoid nested parallelism
+  ipc_options->options->use_threads = false;

Review comment:
       That sounds acceptable but I'd like to defer it to a follow up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org