[GitHub] [hbase] comnetwork commented on a change in pull request #3983: HBASE-26494 Using RefCnt to fix the flawed MemStoreLABImpl

[GitBox <gi...@apache.org>]

comnetwork commented on a change in pull request #3983:
URL: https://github.com/apache/hbase/pull/3983#discussion_r776565355



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.java
##########
@@ -264,33 +270,31 @@ public void close() {
     }
     // We could put back the chunks to pool for reusing only when there is no
     // opening scanner which will read their data
-    int count  = openScannerCount.get();
-    if(count == 0) {
-      recycleChunks();
-    }
+    this.refCnt.release();
   }
 
-  int getOpenScannerCount() {
-    return this.openScannerCount.get();
+  /**
+   * This method is only used for test.
+   * @return
+   */
+  int getRefCntValue() {

Review comment:
       @Apache9 , thank you very much for review , already used RestrictedApi to fix the problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org