You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Pete Wyckoff (JIRA)" <ji...@apache.org> on 2008/10/13 02:56:44 UTC
[jira] Created: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
-----------------------------------------------------------------------------------
Key: HADOOP-4399
URL: https://issues.apache.org/jira/browse/HADOOP-4399
Project: Hadoop Core
Issue Type: Bug
Components: contrib/fuse-dfs
Reporter: Pete Wyckoff
Fix For: 0.20.0
for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642295#action_12642295 ]
Hudson commented on HADOOP-4399:
--------------------------------
Integrated in Hadoop-trunk #640 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/])
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639200#action_12639200 ]
Pete Wyckoff commented on HADOOP-4399:
--------------------------------------
TestJobQueueInformation failed because of https://issues.apache.org/jira/browse/HADOOP-4378.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639188#action_12639188 ]
Hadoop QA commented on HADOOP-4399:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392026/HADOOP-4399.1.txt
against trunk revision 704186.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3451/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3451/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3451/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3451/console
This message is automatically generated.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Status: Open (was: Patch Available)
this patch it turns out did not capture all concurrency problems.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Attachment: TEST-TestFuseDFS.txt
the (successful) output of ant -Dlibhdfs=1 -Dfusedfs=1 -Dtestcase=TestFuseDFS
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Fix Version/s: (was: 0.20.0)
0.19.0
Assignee: Pete Wyckoff
Affects Version/s: 0.19.0
Status: Patch Available (was: Open)
building on hadoop-4397, I did the following:
1. protect dfs_read accesses to the read buffer with a critical section based on a per file handle mutex.
2. open inits the per file handle mutex
3. release destroys the mutex
Also put a comment in dfs_getattr and a "soft" assertion that dfs->fs global filesystem handle is already set in dfs_init.
No new tests as this is a concurrency fix, but all the existing 10 tests pass.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639271#action_12639271 ]
Pete Wyckoff commented on HADOOP-4399:
--------------------------------------
ready to commit.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640392#action_12640392 ]
Zheng Shao commented on HADOOP-4399:
------------------------------------
+1
Talked with Pete. Looks good to me.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Status: Patch Available (was: Open)
submitting for hudson.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4399:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Pete!
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639250#action_12639250 ]
Zheng Shao commented on HADOOP-4399:
------------------------------------
+1 Code looks good.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Attachment: HADOOP-4399.3.txt
fixed some comments.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Attachment: HADOOP-4399.2.txt
this is the ubber patch that fixes all concurrency issues for all .
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Attachment: TEST-TestFuseDFS.txt
newest patch's output of ant -Dlibhdfs=1 -Dfusedfs=1 -Dtestcase=TestFuseDFS test-contrib.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Attachment: HADOOP-4399.1.txt
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640419#action_12640419 ]
Hadoop QA commented on HADOOP-4399:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392297/HADOOP-4399.3.txt
against trunk revision 705420.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3479/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3479/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3479/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3479/console
This message is automatically generated.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4399:
-------------------------------------
Fix Version/s: (was: 0.19.0)
0.18.2
This fix is needed for 0.18.2 release as well.
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640610#action_12640610 ]
Pete Wyckoff commented on HADOOP-4399:
--------------------------------------
this is ready to commit please.
thx, pete
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt, HADOOP-4399.2.txt, HADOOP-4399.3.txt, TEST-TestFuseDFS.txt, TEST-TestFuseDFS.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4399) fuse-dfs per FD context is not
thread safe and can cause segfaults and corruptions
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4399:
---------------------------------
Priority: Blocker (was: Major)
> fuse-dfs per FD context is not thread safe and can cause segfaults and corruptions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4399
> URL: https://issues.apache.org/jira/browse/HADOOP-4399
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Affects Versions: 0.19.0
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4399.1.txt
>
>
> for reads, optimal solution would be to have a per thread (per FD) context - including the buffer. Otherwise, protect the FD context with a mutex as in hadoop-4397 and hadoop-4398.
> for writes, should just protect the context with a mutex as in hadoop-4398.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.