Re: [PR] feat(helm): add helm-docs, yamllint, and helmfmt for chart quality [iggy]

["tungtose (via GitHub)" <gi...@apache.org>]

tungtose commented on code in PR #3070:
URL: https://github.com/apache/iggy/pull/3070#discussion_r3039451270


##########
.github/actions/utils/setup-helm-tools/action.yml:
##########
@@ -51,17 +71,37 @@ runs:
           exit 1
         fi
 
-    - name: Install Helm and optional kind
+    - name: Install Helm and optional kind/helm-docs
       shell: bash
       env:
         HELM_VERSION: ${{ inputs.helm-version }}
         HELM_CHECKSUM: ${{ inputs.helm-checksum }}
         KIND_VERSION: ${{ inputs.kind-version }}
         KIND_CHECKSUM: ${{ inputs.kind-checksum }}
+        HELM_DOCS_VERSION: ${{ inputs.helm-docs-version }}
+        HELM_DOCS_CHECKSUM: ${{ inputs.helm-docs-checksum }}
       run: |
         set -euo pipefail
         args=()
         if [[ "${{ inputs.install-kind }}" == "true" ]]; then
           args+=(--install-kind)
         fi
+        if [[ "${{ inputs.install-helm-docs }}" == "true" ]]; then
+          args+=(--install-helm-docs)
+        fi
         scripts/ci/setup-helm-tools.sh "${args[@]}"
+
+    - name: Install yamllint
+      if: inputs.install-yamllint == 'true'
+      shell: bash
+      run: pip install yamllint
+
+    - name: Install helmfmt
+      if: inputs.install-helmfmt == 'true'
+      shell: bash
+      run: |

Review Comment:
   It would be better if we had `checksum verification` here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org