You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/07/21 11:53:19 UTC
[GitHub] [camel-k] gansheer opened a new pull request, #4590: fix(core): Remove ownership from CamelCatalog on builder image IS
gansheer opened a new pull request, #4590:
URL: https://github.com/apache/camel-k/pull/4590
Fix #4569
This will remove the ownership from the CamelCatalog on the build image ImageStream resource. It will be kept when the camel-k operator is removed.
The side effects this modification is that any uninstall won't remove the ImageStream so it needs to be done manually.
**Release Note**
```release-note
fix(core): Remove ownership from CamelCatalog on builder image IS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4590: fix(core): Remove ownership from CamelCatalog on builder image IS
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4590:
URL: https://github.com/apache/camel-k/pull/4590#issuecomment-1647586872
> I think that it is a best practice to chain resource ownership. Removing it leads to a resource which is unbounded. Although we solve this problem, we open another one. IMO, the solution given in [#4569 (comment)](https://github.com/apache/camel-k/issues/4569#issuecomment-1644164845) is good enough.
Ok, I will see to add the solution somewhere in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer closed pull request #4590: fix(core): Remove ownership from CamelCatalog on builder image IS
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer closed pull request #4590: fix(core): Remove ownership from CamelCatalog on builder image IS
URL: https://github.com/apache/camel-k/pull/4590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #4590: fix(core): Remove ownership from CamelCatalog on builder image IS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4590:
URL: https://github.com/apache/camel-k/pull/4590#issuecomment-1645468168
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org