You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2020/01/10 13:15:56 UTC

svn commit: r1872596 - /httpd/test/framework/trunk/t/apache/expr_string.t

Author: jorton
Date: Fri Jan 10 13:15:55 2020
New Revision: 1872596

URL: http://svn.apache.org/viewvc?rev=1872596&view=rev
Log:
Use t_cmp for a test which keeps failing in CI.

Modified:
    httpd/test/framework/trunk/t/apache/expr_string.t

Modified: httpd/test/framework/trunk/t/apache/expr_string.t
URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/apache/expr_string.t?rev=1872596&r1=1872595&r2=1872596&view=diff
==============================================================================
--- httpd/test/framework/trunk/t/apache/expr_string.t (original)
+++ httpd/test/framework/trunk/t/apache/expr_string.t Fri Jan 10 13:15:55 2020
@@ -3,7 +3,7 @@ use warnings FATAL => 'all';
 
 use Apache::Test;
 use Apache::TestRequest;
-use Apache::TestUtil qw(t_write_file t_start_error_log_watch t_finish_error_log_watch);
+use Apache::TestUtil qw(t_write_file t_start_error_log_watch t_finish_error_log_watch t_cmp);
 
 use File::Spec;
 
@@ -97,8 +97,7 @@ foreach my $t (@test_cases) {
                              [ ]\(log_transaction)  # trailing hook info (LogLevel debug and higher)
                            }x ) {
             my $result = $1;
-            print "Got '$result', expected '$expect'\n";
-            ok($result eq $expect);
+            ok t_cmp($result, $expect, "log message @msg didn't match");
         }
         else {
             print "Can't extract expr result from log message:\n@msg\n";