You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/06/10 01:20:41 UTC
Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9826
https://issues.apache.org/jira/browse/MESOS-9826
Repository: mesos
Description
-------
If `namespaces/ipc` isolator is not enabled, for backward
compatibility /dev/shm will still be handled in `filesystem/linux`
isolator as before. Otherwise, both /dev/shm and IPC namespace
will be handled by `namespaces/ipc` isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
Diff: https://reviews.apache.org/r/70820/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review215772
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775, 70798, 70820]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 10, 2019, 1:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 10, 2019, 1:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review215775
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775, 70798, 70820]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 10, 2019, 4:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 10, 2019, 4:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216550
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 766 (patched)
<https://reviews.apache.org/r/70820/#comment303764>
You meant "not enabled"?
- Gilbert Song
On June 12, 2019, 7:32 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:32 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Gilbert Song <so...@gmail.com>.
> On June 20, 2019, 5:27 p.m., Gilbert Song wrote:
> > could we consider to do the decouple now?
probably still need a deprecation cycle :(
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216030
-----------------------------------------------------------
On June 12, 2019, 7:32 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:32 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Qian Zhang <zh...@gmail.com>.
> On June 21, 2019, 8:27 a.m., Gilbert Song wrote:
> > could we consider to do the decouple now?
>
> Gilbert Song wrote:
> probably still need a deprecation cycle :(
Yes, and I have added a TODO in mesos.proto for the deprecation cycle.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216030
-----------------------------------------------------------
On June 12, 2019, 10:32 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 10:32 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216030
-----------------------------------------------------------
could we consider to do the decouple now?
- Gilbert Song
On June 12, 2019, 7:32 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:32 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/
-----------------------------------------------------------
(Updated June 12, 2019, 10:32 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9826
https://issues.apache.org/jira/browse/MESOS-9826
Repository: mesos
Description
-------
If `namespaces/ipc` isolator is not enabled, for backward
compatibility /dev/shm will still be handled in `filesystem/linux`
isolator as before. Otherwise, both /dev/shm and IPC namespace
will be handled by `namespaces/ipc` isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
Diff: https://reviews.apache.org/r/70820/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review215805
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775, 70798, 70820]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 10, 2019, 1:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 10, 2019, 1:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>