You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/18 16:20:10 UTC
[GitHub] [lucene-solr] cpoerschke opened a new pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
cpoerschke opened a new pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890
As part of https://issues.apache.org/jira/browse/LUCENE-8626 I noticed that we have both
* https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/ConfigSetsAPITest.java and
* https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java which is mildly confusing.
I also note that
* https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPIExclusivity.java and
* https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPIZkFailure.java exist in the same package i.e. this part of the code base favours `Test*.java` naming.
Something like "TestConfigSetsAPISolrCloud" more accurately describes what the "ConfigSetsAPITest" test does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-702776305
> ... if adding of `ConfigSetsAPITest` functionality to `TestConfigSetsAPI` might be better? ...
Looking more closely, there seem to be sufficient differences between the tests i.e. them remaining separate they would be clearer. However, `TestConfigSetsAPIShareSchema` could be a better alternative name than `TestConfigSetsAPISolrCloud`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
Posted by GitBox <gi...@apache.org>.
tflobbe commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-695130944
Christine, if you could give me a couple days, I'm doing some refactor on `TestConfigSetsAPI` to improve and add some more tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
Posted by GitBox <gi...@apache.org>.
tflobbe commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-695141609
I refer to https://github.com/apache/lucene-solr/pull/1892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-698439045
> ... if you could give me a couple days ... #1892
Sure, no problem at all.
Now that `TestConfigSetsAPI` extends `SolrCloudTestCase` too, I wonder
* if `TestConfigSetsAPISolrCloud` would still be a good replacement for the `ConfigSetsAPITest` still, or
* if adding of `ConfigSetsAPITest` functionality to `TestConfigSetsAPI` might be better?
(Haven't looked at details as yet.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPISolrCloud
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-698439045
> ... if you could give me a couple days ... #1892
Sure, no problem at all.
Now that `TestConfigSetsAPI` extends `SolrCloudTestCase` too, I wonder
* if `TestConfigSetsAPISolrCloud` would still be a good replacement for the `ConfigSetsAPITest` still, or
* if adding of `ConfigSetsAPITest` functionality to `TestConfigSetsAPI` might be better?
(Haven't looked at details as yet.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke merged pull request #1890: Rename ConfigSetsAPITest to TestConfigSetsAPIShareSchema
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org