You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/09 02:23:05 UTC
[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7131
to review the following change.
Change subject: Fix all 'misc-string-compare' warnings from clang-tidy
......................................................................
Fix all 'misc-string-compare' warnings from clang-tidy
See https://clang.llvm.org/extra/clang-tidy/checks/misc-string-compare.html
for details
(auto-generated using clang-tidy --fix with only this check enabled)
Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
---
M src/kudu/common/partition.cc
M src/kudu/util/compression/compression_codec.cc
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/7131/1
--
To view, visit http://gerrit.cloudera.org:8080/7131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix all 'misc-string-compare' warnings from clang-tidy
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix all 'misc-string-compare' warnings from clang-tidy
......................................................................
Fix all 'misc-string-compare' warnings from clang-tidy
See https://clang.llvm.org/extra/clang-tidy/checks/misc-string-compare.html
for details
(auto-generated using clang-tidy --fix with only this check enabled)
Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
Reviewed-on: http://gerrit.cloudera.org:8080/7131
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/common/partition.cc
M src/kudu/util/compression/compression_codec.cc
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix all 'misc-string-compare' warnings from clang-tidy
......................................................................
Patch Set 2: Code-Review+2
forwarding +2
--
To view, visit http://gerrit.cloudera.org:8080/7131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18e609172eda7793f79ed9bb8ddafdf3b85d5fb0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No