You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/12 02:05:35 UTC

[GitHub] [dolphinscheduler] SbloodyS opened a new pull request, #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

SbloodyS opened a new pull request, #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   close #10412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   export DATABASE=${DATABASE:-postgresql} 
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server  
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895089105


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   It's better not to modify config file. Let the user do `export DATABASE=h2` before running the daemon script. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090222


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   `export DATABASE=h2` before daemon script must work otherwise it's a bug of our script. I can take a look at that later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS merged pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS merged PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   
   export DATABASE=${DATABASE:-postgresql}
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh```. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   export DATABASE=${DATABASE:-postgresql}
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh```. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895127655


##########
dolphinscheduler-standalone-server/src/main/bin/start.sh:
##########
@@ -19,6 +19,7 @@
 BIN_DIR=$(dirname $0)
 DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
 
+export DATABASE=h2

Review Comment:
   ```suggestion
   export DATABASE=${DATABASE:-h2}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   
   export DATABASE=${DATABASE:-postgresql} 
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `export DATABASE=${DATABASE:-postgresql}  
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server  
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090015


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   > It's better not to modify config file. Let the user do `export DATABASE=h2` before running the daemon script.
   
   that a good idea too, before that I think we should add option to `dolphinscheduler-deamon.sh` like `--no-overwrite` or some other things, to determin whether we should overwrite env file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   export DATABASE=${DATABASE:-postgresql}
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   > export DATABASE=${DATABASE:-postgresql}  
   > sh ./bin/dolphinscheduler-daemon.sh start standalone-server  
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895089368


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   ```export DATABASE=h2``` before execute daemon script will be overwrite by ```export DATABASE``` in the ```dolphinscheduler-daemon.sh```. I think we can use the method proposed by @zhongjiajie  in wechat. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `shell
   export DATABASE=${DATABASE:-postgresql}
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh```. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   ` shell
   export DATABASE=${DATABASE:-postgresql}
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh```. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895090334


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   For example
   `
   export DATABASE=${DATABASE:-postgresql}  
   sh ./bin/dolphinscheduler-daemon.sh start standalone-server  
   `
   
   The `script/dolphinscheduler-daemon.sh's` `overwrite_server_env()` will overwrite the `standalone-server/conf/dolphinscheduler_env.sh`. And `standalone/bin/start.sh` will `source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"`. It will overwrite the `export DATABASE=${DATABASE:-postgresql}` from the beginning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#discussion_r895089713


##########
docs/docs/en/guide/installation/standalone.md:
##########
@@ -19,9 +19,16 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 There is a standalone startup script in the binary compressed package, which can be quickly started after extraction. Switch to a user with sudo permission and run the script:
 
 ```shell
-# Extract and start Standalone Server
+# Extract Standalone Server
 tar -xvzf apache-dolphinscheduler-*-bin.tar.gz
 cd apache-dolphinscheduler-*-bin
+```
+
+### Modify dolphinscheduler_env.sh

Review Comment:
   > ```export DATABASE=h2``` before execute daemon script will be overwrite by ```export DATABASE``` in the ```dolphinscheduler-daemon.sh```.
   
   Why do you think so? The mechanism by design is to allow not modifying config file to override config in command line. If this doesn't work it is a bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#issuecomment-1153095732

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10414](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff280bd) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/088c5e8ae2b86d70870db3c594378192657a0d41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (088c5e8) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev   #10414      +/-   ##
   ============================================
   - Coverage     40.56%   40.53%   -0.04%     
   - Complexity     4766     4772       +6     
   ============================================
     Files           877      877              
     Lines         35623    35701      +78     
     Branches       3945     3970      +25     
   ============================================
   + Hits          14450    14470      +20     
   - Misses        19743    19787      +44     
   - Partials       1430     1444      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/dolphinscheduler/service/corn/CronUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvY29ybi9Dcm9uVXRpbHMuamF2YQ==) | `64.77% <0.00%> (-5.60%)` | :arrow_down: |
   | [...cheduler/api/service/impl/ExecutorServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9FeGVjdXRvclNlcnZpY2VJbXBsLmphdmE=) | `40.10% <0.00%> (-2.59%)` | :arrow_down: |
   | [.../server/master/runner/WorkflowExecuteRunnable.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvV29ya2Zsb3dFeGVjdXRlUnVubmFibGUuamF2YQ==) | `7.75% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `80.95% <0.00%> (ø)` | |
   | [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `53.33% <0.00%> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `52.77% <0.00%> (+1.38%)` | :arrow_up: |
   | [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `40.00% <0.00%> (+2.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [088c5e8...ff280bd](https://codecov.io/gh/apache/dolphinscheduler/pull/10414?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10414: [Fix-10412] [Standalone] Failed to start standalone server according to the official document

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10414:
URL: https://github.com/apache/dolphinscheduler/pull/10414#issuecomment-1153099531

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10414)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10414&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10414&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10414&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org