You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/04 16:31:05 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #9929: Issue#9845.fix Binding tables using 'join .. on .. and column_x=?' or 'join .. on .. and cloumn_x in (?)' can not sharding correct.
codecov-io commented on pull request #9929:
URL: https://github.com/apache/shardingsphere/pull/9929#issuecomment-813061239
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=h1) Report
> Merging [#9929](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=desc) (52f9781) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9158d6d499732a919f1cb3aa8dad1e2327a879b3?el=desc) (9158d6d) will **increase** coverage by `0.21%`.
> The diff coverage is `37.71%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9929 +/- ##
============================================
+ Coverage 67.75% 67.97% +0.21%
+ Complexity 678 677 -1
============================================
Files 1676 1684 +8
Lines 28187 28312 +125
Branches 5001 5027 +26
============================================
+ Hits 19099 19245 +146
+ Misses 7673 7641 -32
- Partials 1415 1426 +11
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../protocol/mysql/constant/MySQLServerErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMU2VydmVyRXJyb3JDb2RlLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../context/auth/GovernanceAuthenticationContext.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC9hdXRoL0dvdmVybmFuY2VBdXRoZW50aWNhdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ingsphere/governance/core/lock/GovernanceLock.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL0dvdmVybmFuY2VMb2NrLmphdmE=) | `32.14% <0.00%> (-1.20%)` | `0.00 <0.00> (ø)` | |
| [...e/governance/core/registry/RegistryCenterNode.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlck5vZGUuamF2YQ==) | `83.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/shardingsphere/infra/check/SQLCheckEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jaGVjay9TUUxDaGVja0VuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/infra/check/auth/AuthenticationSQLChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jaGVjay9hdXRoL0F1dGhlbnRpY2F0aW9uU1FMQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/infra/metadata/auth/AuthenticationContext.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9hdXRoL0F1dGhlbnRpY2F0aW9uQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../metadata/auth/model/user/ShardingSphereUsers.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9hdXRoL21vZGVsL3VzZXIvU2hhcmRpbmdTcGhlcmVVc2Vycy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/infra/metadata/engine/MetadataRefreshEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9lbmdpbmUvTWV0YWRhdGFSZWZyZXNoRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nfra/metadata/engine/MetadataRefresherFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9lbmdpbmUvTWV0YWRhdGFSZWZyZXNoZXJGYWN0b3J5LmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [74 more](https://codecov.io/gh/apache/shardingsphere/pull/9929/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=footer). Last update [4ee02a6...52f9781](https://codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org