You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2016/04/08 06:57:40 UTC
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/996
TAJO-2115: Change the size of the VALUE_ column in OPTIONS table
This patch just updates the ``VALUE_`` column size of ``OPTIONS`` table. Existing codes of catalog module have remained static. Here are corrections as following:
DBMS | Existing Type | Updated Type
-------------------|----------------------|--------------------------
Derby | VARCHAR(4000) | LONG VARCHAR
MySQL | VARCHAR(4000) | TEXT
MariaDB | VARCHAR(4000) | TEXT
PostgreSQL | VARCHAR(4000) | TEXT
Oracle | VARCHAR2(4000) | LONG
I referenced following sites.
* https://db.apache.org/derby/docs/10.1/ref/rrefsqlj15147.html
* https://docs.oracle.com/cd/B19306_01/java.102/b14188/datamap.htm
* https://en.wikibooks.org/wiki/Converting_MySQL_to_PostgreSQL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-2115
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/996.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #996
----
commit 865da9634d56b768ffff7a4a2d1d7986a6db112c
Author: JaeHwa Jung <bl...@apache.org>
Date: 2016-04-08T03:38:18Z
TAJO-2115: Change the size of the VALUE_ column in OPTIONS table
commit 184750b1647f2e24e9fd7a20e94565c8b14151c9
Author: JaeHwa Jung <bl...@apache.org>
Date: 2016-04-08T03:39:05Z
Update the base version of Catalog
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-219911267
I mean, this issue is not addressing the fundamental problem. I believe that we need to devise a better way to map Tajo columns and HBase columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-218357570
Could you rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner closed the pull request at:
https://github.com/apache/tajo/pull/996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-220234259
This patch is a temporary solution. We need to solve the fundamental problem about this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-218360273
This is a temporal solution. We need to investigate a better way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-219878172
@jihoonson In this issue or in another issue?
@blrunner It seems to need rebase again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2115: Change the size of the VALUE_ column...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/996#issuecomment-218360939
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---