You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/25 07:26:16 UTC
[GitHub] [arrow] AlvinJ15 opened a new pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
AlvinJ15 opened a new pull request #12713:
URL: https://github.com/apache/arrow/pull/12713
Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/400| `77e2a113` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/386| `77e2a113` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/382| `77e2a113` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/396| `77e2a113` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/399| `556ee23e` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/385| `556ee23e` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/395| `556ee23e` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1078732877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/400| `77e2a113` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/386| `77e2a113` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/382| `77e2a113` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/396| `77e2a113` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/399| `556ee23e` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/385| `556ee23e` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/386| `556ee23e` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/395| `556ee23e` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/400| `77e2a113` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/386| `77e2a113` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/382| `77e2a113` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/396| `77e2a113` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/399| `556ee23e` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/385| `556ee23e` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/395| `556ee23e` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#discussion_r836492655
##########
File path: cpp/src/arrow/python/gdb.cc
##########
@@ -98,13 +96,13 @@ std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,
} // namespace
-void TestSession() {
+Status TestSession() {
Review comment:
Similarly, this change doesn't seem necessary.
##########
File path: cpp/src/arrow/python/gdb.cc
##########
@@ -98,13 +96,13 @@ std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,
} // namespace
-void TestSession() {
+Status TestSession() {
// We define local variables for all types for which we want to test
// pretty-printing.
// Then, at the end of this function, we trap to the debugger, so that
// test instrumentation can print values from this frame by interacting
// with the debugger.
- // The test instrumentation is in pyarrow/tests/test_gdb.py
+ // The test instrumentation is in pyarrow/tests/test_gdb.pytest_gdb.py
Review comment:
I think that change is not deliberate, is it?
##########
File path: cpp/src/arrow/python/gdb.cc
##########
@@ -82,13 +82,11 @@ class UuidType : public ExtensionType {
std::string Serialize() const override { return "uuid-serialized"; }
};
-// TODO migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>?
-
-std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,
- util::string_view json, int64_t offset = 0,
- int64_t length = -1) {
- std::shared_ptr<Array> array;
- ARROW_CHECK_OK(ArrayFromJSON(ty, json, &array));
+Result<std::shared_ptr<Array>> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,
+ util::string_view json,
+ int64_t offset = 0,
+ int64_t length = -1) {
+ ARROW_ASSIGN_OR_RAISE(auto array, ArrayFromJSON(ty, json));
Review comment:
I don't think this change is necessary, instead, you could just have:
```suggestion
std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,
util::string_view json, int64_t offset = 0,
int64_t length = -1) {
auto array = *ArrayFromJSON(ty, json);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1080628948
Er, whoops. Thanks for the changes, there's just a minor fix we should make. I think the S3 test issues are due to ARROW-16043, and we need to figure out why the GDB tests fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Failed :arrow_down:0.0% :arrow_up:1.43%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/400| `77e2a113` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/386| `77e2a113` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/382| `77e2a113` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/396| `77e2a113` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/399| `556ee23e` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/385| `556ee23e` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/386| `556ee23e` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/395| `556ee23e` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#discussion_r836407569
##########
File path: cpp/src/arrow/python/gdb.h
##########
@@ -23,7 +23,7 @@ namespace arrow {
namespace gdb {
ARROW_PYTHON_EXPORT
-void TestSession();
+Status TestSession();
Review comment:
We need to update the binding signature on the Cython side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#discussion_r835558081
##########
File path: cpp/src/arrow/python/gdb.cc
##########
@@ -29,6 +29,7 @@
#include "arrow/scalar.h"
#include "arrow/table.h"
#include "arrow/type.h"
+#include "arrow/testing/gtest_util.h"
Review comment:
I'm not sure we want this linked to googletest, we should stick to the old version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/400| `77e2a113` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/386| `77e2a113` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/382| `77e2a113` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/396| `77e2a113` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/399| `556ee23e` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/385| `556ee23e` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/381| `556ee23e` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/395| `556ee23e` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Finished :arrow_down:0.8% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12713:
URL: https://github.com/apache/arrow/pull/12713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851ae98eb7358f5166 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b254b0af326e4794931278c7946eb9d3...32590577bdea45f3bd44aa1585f651b8/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/53ffbfea966944508200acac11e7e12c...cf194cd07f5d4c3ba20c6f3a1cf982bf/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76bd3c06190346fdabcf28f93ce7ca8e...698b615c2670411183573c292bd921e0/)
[Finished :arrow_down:0.34% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8e71e3381424883b1e99f7489302c0f...7dcf2329e26f4ab6ac6661b48e34c6e3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org