You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/01 23:51:43 UTC

[GitHub] [incubator-druid] justinborromeo opened a new issue #7397: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec

justinborromeo opened a new issue #7397: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec
URL: https://github.com/apache/incubator-druid/issues/7397
 
 
   ### Motivation
   
   The configurable segment and row limits for time-ordered scans introduced in #7133 should be overridable through query parameters.  Since memory usage is proportional to # of dimensions being queried,  I think it makes sense to allow users to tune the limits based on the specific query they issue (as opposed to setting it in the config at startup).  This would allow for greater flexibility from a user's perspective.
   
   ### Proposed changes
   
    I propose adding two optional fields `maxRowsQueuedForOrdering` and `maxSegmentPartitionsOrderedInMemory` to the scan query object.  The default values will be their corresponding config properties.
   
   ### Rationale
   
   I don't think there's another way to do this
   
   ### Operational impact
   
   Likely none since #7133 hasn't been released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org