You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ki...@apache.org on 2022/03/31 12:07:17 UTC
[incubator-seatunnel] branch dev updated: [Chore]Modify irregular code (#1633)
This is an automated email from the ASF dual-hosted git repository.
kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new a41d4a5 [Chore]Modify irregular code (#1633)
a41d4a5 is described below
commit a41d4a585a2938c9847a9e399f9b3cf984093962
Author: Kirs <ki...@apache.org>
AuthorDate: Thu Mar 31 20:07:11 2022 +0800
[Chore]Modify irregular code (#1633)
---
.../apache/seatunnel/flink/util/ConfigKeyName.java | 5 ++++
.../org/apache/seatunnel/flink/jdbc/Config.java | 28 +++++++++++-----------
.../apache/seatunnel/utils/CompressionUtils.java | 2 +-
3 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/ConfigKeyName.java b/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/ConfigKeyName.java
index 4b7c559..88b7675 100644
--- a/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/ConfigKeyName.java
+++ b/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/ConfigKeyName.java
@@ -18,6 +18,11 @@
package org.apache.seatunnel.flink.util;
public class ConfigKeyName {
+
+ private ConfigKeyName() {
+ throw new IllegalStateException("Utility class");
+ }
+
public static final String TIME_CHARACTERISTIC = "execution.time-characteristic";
public static final String BUFFER_TIMEOUT_MILLIS = "execution.buffer.timeout";
public static final String PARALLELISM = "execution.parallelism";
diff --git a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/jdbc/Config.java b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/jdbc/Config.java
index 4e56eec..d3ff370 100644
--- a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/jdbc/Config.java
+++ b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/jdbc/Config.java
@@ -24,71 +24,71 @@ import org.apache.seatunnel.flink.jdbc.source.JdbcSource;
* Jdbc source {@link JdbcSource} and
* sink {@link JdbcSink} configuration parameters
*/
-public interface Config {
+public final class Config {
/**
* Parallelism of the source or sink
*/
- String PARALLELISM = "parallelism";
+ public static final String PARALLELISM = "parallelism";
/**
* Jdbc driver for source or sink
*/
- String DRIVER = "driver";
+ public static final String DRIVER = "driver";
/**
* Jdbc Url for source or sink
*/
- String URL = "url";
+ public static final String URL = "url";
/**
* Jdbc username for source or sink
*/
- String USERNAME = "username";
+ public static final String USERNAME = "username";
/**
* Jdbc query for source or sink
*/
- String QUERY = "query";
+ public static final String QUERY = "query";
/**
* Jdbc password for source or sink
*/
- String PASSWORD = "password";
+ public static final String PASSWORD = "password";
/**
* Jdbc fetch size for source
*/
- String SOURCE_FETCH_SIZE = "fetch_size";
+ public static final String SOURCE_FETCH_SIZE = "fetch_size";
/**
* Jdbc batch size for sink
*/
- String SINK_BATCH_SIZE = "batch_size";
+ public static final String SINK_BATCH_SIZE = "batch_size";
/**
* Jdbc batch interval for sink
*/
- String SINK_BATCH_INTERVAL = "batch_interval";
+ public static final String SINK_BATCH_INTERVAL = "batch_interval";
/**
* Jdbc max batch retries for sink
*/
- String SINK_BATCH_MAX_RETRIES = "batch_max_retries";
+ public static final String SINK_BATCH_MAX_RETRIES = "batch_max_retries";
/**
* Jdbc partition column name
*/
- String PARTITION_COLUMN = "partition_column";
+ public static final String PARTITION_COLUMN = "partition_column";
/**
* Jdbc partition upper bound
*/
- String PARTITION_UPPER_BOUND = "partition_upper_bound";
+ public static final String PARTITION_UPPER_BOUND = "partition_upper_bound";
/**
* Jdbc partition lower bound
*/
- String PARTITION_LOWER_BOUND = "partition_lower_bound";
+ public static final String PARTITION_LOWER_BOUND = "partition_lower_bound";
}
diff --git a/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/utils/CompressionUtils.java b/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/utils/CompressionUtils.java
index 2cd45af..bd8f407 100644
--- a/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/utils/CompressionUtils.java
+++ b/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/utils/CompressionUtils.java
@@ -78,7 +78,7 @@ public final class CompressionUtils {
}
});
tarOut.finish();
- LOGGER.info("Creating tar file '{}'.", outputFile.toString());
+ LOGGER.info("Creating tar file '{}'.", outputFile);
} catch (IOException e) {
LOGGER.error("Error when tar directory '{}' to file '{}'.", inputDir, outputFile);
throw e;