You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by eolivelli <gi...@git.apache.org> on 2016/11/25 10:33:21 UTC
[GitHub] zookeeper pull request #116: ZOOKEEPER-2460 Remove javacc dependency from pu...
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/116
ZOOKEEPER-2460 Remove javacc dependency from public Maven pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper ZOOKEEPER-2460
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 2440a669745ad4a07416e485e70801522edec1b6
Author: eolivelli <eo...@gmail.com>
Date: 2016-11-25T10:32:10Z
ZOOKEEPER-2460 Remove javacc dependency from public Maven pom
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #116: ZOOKEEPER-2460 Remove javacc dependency from public Ma...
Posted by arshadmohammad <gi...@git.apache.org>.
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/116
Now after this fix, javacc jar is not present in the zookeeper tar ball. So javacc.LICENSE.txt also should not be present. Can you delete javacc.LICENSE.txt from the src\java\lib and include in this MR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #116: ZOOKEEPER-2460 Remove javacc dependency from public Ma...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/116
I will update the PR as soon as possible. Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #116: ZOOKEEPER-2460 Remove javacc dependency from public Ma...
Posted by arshadmohammad <gi...@git.apache.org>.
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/116
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #116: ZOOKEEPER-2460 Remove javacc dependency from pu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #116: ZOOKEEPER-2460 Remove javacc dependency from public Ma...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/116
@arshadmohammad I have deleted the file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---