You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/04 01:58:10 UTC
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #548: Update Nacos SDK version
codecov-commenter edited a comment on pull request #548:
URL: https://github.com/apache/dubbo-go/pull/548#issuecomment-636449952
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=h1) Report
> Merging [#548](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=desc) into [1.4](https://codecov.io/gh/apache/dubbo-go/commit/c50325bbbe03914eabb59cd5cd0634a44b1faa98&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `56.41%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.4 #548 +/- ##
==========================================
- Coverage 67.24% 67.04% -0.21%
==========================================
Files 174 174
Lines 9261 9258 -3
==========================================
- Hits 6228 6207 -21
- Misses 2428 2441 +13
- Partials 605 610 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `70.71% <0.00%> (-0.45%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `68.18% <0.00%> (-11.82%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `69.15% <63.33%> (+11.89%)` | :arrow_up: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `62.69% <100.00%> (+0.90%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-9.38%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `72.50% <0.00%> (-5.00%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0.00%> (-2.44%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-1.87%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/548/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=footer). Last update [c50325b...4de80e5](https://codecov.io/gh/apache/dubbo-go/pull/548?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org