You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Josh Elser <el...@apache.org> on 2018/03/16 20:47:38 UTC
Looking at an hbase-thirdparty release
Give a shout if there's anything that you all think would be good to
include in a new hbase-thirdparty release for HBase 2.0.
I'm pulling in commons-cli as per
https://issues.apache.org/jira/browse/HBASE-20201.
If there's more that should come in, please let me know!
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
On 3/19/18 11:02 AM, Josh Elser wrote:
>
>
> On 3/16/18 8:06 PM, Stack wrote:
>> On Fri, Mar 16, 2018 at 3:48 PM, Josh Elser <el...@apache.org> wrote:
>>
>>> No qualms from me. 3.5.1 the desired version?
>>>
>>>
>> Yeah. Hopefully just a pom version bump.
>>
>>
>>
>>> The reason that brought me here was nothing that we do in our build
>>> (running MR jobs via `hadoop jar`), so I don't think we need to rush.
>>>
>>>
>> On the no rush, this release has to happen before I can put up an RC0.
>> Was
>> hoping to do that in the next week or two. Just saying...
>>
>
> Understood. Am looking at this one today. Thanks for keeping me honest :)
All -- any spare review cycles for these would be appreciated. I think
we're essentially in "patch available" state for a 2.1.0 rc0. They're
all pretty straightforward.
https://issues.apache.org/jira/issues/?jql=project%20%3D%20HBASE%20AND%20fixVersion%20%3D%20thirdparty-2.1.0%20and%20resolution%20%3D%20unresolved
(Thanks Umesh for a review already :))
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
On 3/16/18 8:06 PM, Stack wrote:
> On Fri, Mar 16, 2018 at 3:48 PM, Josh Elser <el...@apache.org> wrote:
>
>> No qualms from me. 3.5.1 the desired version?
>>
>>
> Yeah. Hopefully just a pom version bump.
>
>
>
>> The reason that brought me here was nothing that we do in our build
>> (running MR jobs via `hadoop jar`), so I don't think we need to rush.
>>
>>
> On the no rush, this release has to happen before I can put up an RC0. Was
> hoping to do that in the next week or two. Just saying...
>
Understood. Am looking at this one today. Thanks for keeping me honest :)
Re: Looking at an hbase-thirdparty release
Posted by Stack <st...@duboce.net>.
On Fri, Mar 16, 2018 at 3:48 PM, Josh Elser <el...@apache.org> wrote:
> No qualms from me. 3.5.1 the desired version?
>
>
Yeah. Hopefully just a pom version bump.
> The reason that brought me here was nothing that we do in our build
> (running MR jobs via `hadoop jar`), so I don't think we need to rush.
>
>
On the no rush, this release has to happen before I can put up an RC0. Was
hoping to do that in the next week or two. Just saying...
S
> On 3/16/18 5:46 PM, Andrew Purtell wrote:
>
>> +1 on protobuf. Any chance we can get a vote period long enough to do a
>> comparison perf / GC test? I can help.
>>
>> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>>
>> Probably too risky to do at this stage in the game but protobuf? We're on
>>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
>>> Guava
>>> is 24.1 now. We're on 22.
>>>
>>> St.Ack
>>> 1. https://github.com/google/protobuf/releases
>>>
>>>
>>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>>
>>> Give a shout if there's anything that you all think would be good to
>>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>>
>>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>>> /browse/HBASE-20201.
>>>>
>>>> If there's more that should come in, please let me know!
>>>>
>>>>
>>>
>>
>>
>>
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
No qualms from me. 3.5.1 the desired version?
The reason that brought me here was nothing that we do in our build
(running MR jobs via `hadoop jar`), so I don't think we need to rush.
On 3/16/18 5:46 PM, Andrew Purtell wrote:
> +1 on protobuf. Any chance we can get a vote period long enough to do a
> comparison perf / GC test? I can help.
>
> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>
>> Probably too risky to do at this stage in the game but protobuf? We're on
>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And Guava
>> is 24.1 now. We're on 22.
>>
>> St.Ack
>> 1. https://github.com/google/protobuf/releases
>>
>>
>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>
>>> Give a shout if there's anything that you all think would be good to
>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>
>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>> /browse/HBASE-20201.
>>>
>>> If there's more that should come in, please let me know!
>>>
>>
>
>
>
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
I'll pull this in today as well. Like you say, this shouldn't have more
issues -- we'll find out soon :)
On 3/17/18 4:20 PM, Mike Drob wrote:
> Yea, I'm not concerned about commons-collections3 v commons-collections4 or
> whatever the latest libs may be. I'm more concerned about collections4.1 v
> 4.2 or something like that, and I really hope that we don't have to redo
> our import statements for each minor release.
>
> On Fri, Mar 16, 2018 at 5:58 PM, Josh Elser <el...@apache.org> wrote:
>
>> Yeah, all of the commons-* projects worry me.
>>
>> Recently, commons-math and commons-collections introduced different GAV
>> and java-package which give me some hope that they'll be OK going forward.
>>
>> Not sure about IO, crypto, and lang..
>>
>>
>> On 3/16/18 6:19 PM, Mike Drob wrote:
>>
>>> commons-collections? I don't know what their minor version compatibility
>>> story is, but that seems like a place that this could easily come up again
>>> in the not so distant future.
>>>
>>> On Fri, Mar 16, 2018 at 4:46 PM, Andrew Purtell <ap...@apache.org>
>>> wrote:
>>>
>>> +1 on protobuf. Any chance we can get a vote period long enough to do a
>>>> comparison perf / GC test? I can help.
>>>>
>>>> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>>>>
>>>> Probably too risky to do at this stage in the game but protobuf? We're on
>>>>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
>>>>>
>>>> Guava
>>>>
>>>>> is 24.1 now. We're on 22.
>>>>>
>>>>> St.Ack
>>>>> 1. https://github.com/google/protobuf/releases
>>>>>
>>>>>
>>>>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>>>>
>>>>> Give a shout if there's anything that you all think would be good to
>>>>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>>>>
>>>>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>>>>> /browse/HBASE-20201.
>>>>>>
>>>>>> If there's more that should come in, please let me know!
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best regards,
>>>> Andrew
>>>>
>>>> Words like orphans lost among the crosstalk, meaning torn from truth's
>>>> decrepit hands
>>>> - A23, Crosstalk
>>>>
>>>>
>>>
>
Re: Looking at an hbase-thirdparty release
Posted by Mike Drob <md...@apache.org>.
Yea, I'm not concerned about commons-collections3 v commons-collections4 or
whatever the latest libs may be. I'm more concerned about collections4.1 v
4.2 or something like that, and I really hope that we don't have to redo
our import statements for each minor release.
On Fri, Mar 16, 2018 at 5:58 PM, Josh Elser <el...@apache.org> wrote:
> Yeah, all of the commons-* projects worry me.
>
> Recently, commons-math and commons-collections introduced different GAV
> and java-package which give me some hope that they'll be OK going forward.
>
> Not sure about IO, crypto, and lang..
>
>
> On 3/16/18 6:19 PM, Mike Drob wrote:
>
>> commons-collections? I don't know what their minor version compatibility
>> story is, but that seems like a place that this could easily come up again
>> in the not so distant future.
>>
>> On Fri, Mar 16, 2018 at 4:46 PM, Andrew Purtell <ap...@apache.org>
>> wrote:
>>
>> +1 on protobuf. Any chance we can get a vote period long enough to do a
>>> comparison perf / GC test? I can help.
>>>
>>> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>>>
>>> Probably too risky to do at this stage in the game but protobuf? We're on
>>>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
>>>>
>>> Guava
>>>
>>>> is 24.1 now. We're on 22.
>>>>
>>>> St.Ack
>>>> 1. https://github.com/google/protobuf/releases
>>>>
>>>>
>>>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>>>
>>>> Give a shout if there's anything that you all think would be good to
>>>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>>>
>>>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>>>> /browse/HBASE-20201.
>>>>>
>>>>> If there's more that should come in, please let me know!
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Best regards,
>>> Andrew
>>>
>>> Words like orphans lost among the crosstalk, meaning torn from truth's
>>> decrepit hands
>>> - A23, Crosstalk
>>>
>>>
>>
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
Yeah, all of the commons-* projects worry me.
Recently, commons-math and commons-collections introduced different GAV
and java-package which give me some hope that they'll be OK going forward.
Not sure about IO, crypto, and lang..
On 3/16/18 6:19 PM, Mike Drob wrote:
> commons-collections? I don't know what their minor version compatibility
> story is, but that seems like a place that this could easily come up again
> in the not so distant future.
>
> On Fri, Mar 16, 2018 at 4:46 PM, Andrew Purtell <ap...@apache.org> wrote:
>
>> +1 on protobuf. Any chance we can get a vote period long enough to do a
>> comparison perf / GC test? I can help.
>>
>> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>>
>>> Probably too risky to do at this stage in the game but protobuf? We're on
>>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
>> Guava
>>> is 24.1 now. We're on 22.
>>>
>>> St.Ack
>>> 1. https://github.com/google/protobuf/releases
>>>
>>>
>>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>>
>>>> Give a shout if there's anything that you all think would be good to
>>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>>
>>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>>> /browse/HBASE-20201.
>>>>
>>>> If there's more that should come in, please let me know!
>>>>
>>>
>>
>>
>>
>> --
>> Best regards,
>> Andrew
>>
>> Words like orphans lost among the crosstalk, meaning torn from truth's
>> decrepit hands
>> - A23, Crosstalk
>>
>
Re: Looking at an hbase-thirdparty release
Posted by Mike Drob <md...@apache.org>.
commons-collections? I don't know what their minor version compatibility
story is, but that seems like a place that this could easily come up again
in the not so distant future.
On Fri, Mar 16, 2018 at 4:46 PM, Andrew Purtell <ap...@apache.org> wrote:
> +1 on protobuf. Any chance we can get a vote period long enough to do a
> comparison perf / GC test? I can help.
>
> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>
> > Probably too risky to do at this stage in the game but protobuf? We're on
> > 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
> Guava
> > is 24.1 now. We're on 22.
> >
> > St.Ack
> > 1. https://github.com/google/protobuf/releases
> >
> >
> > On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
> >
> > > Give a shout if there's anything that you all think would be good to
> > > include in a new hbase-thirdparty release for HBase 2.0.
> > >
> > > I'm pulling in commons-cli as per https://issues.apache.org/jira
> > > /browse/HBASE-20201.
> > >
> > > If there's more that should come in, please let me know!
> > >
> >
>
>
>
> --
> Best regards,
> Andrew
>
> Words like orphans lost among the crosstalk, meaning torn from truth's
> decrepit hands
> - A23, Crosstalk
>
Re: Looking at an hbase-thirdparty release
Posted by Andrew Purtell <ap...@apache.org>.
Let's test out an actual RC
On Mon, Mar 19, 2018 at 11:46 AM, Josh Elser <el...@apache.org> wrote:
> Ran a quick test locally after update and things appear to be in the same
> ballpark.
>
> If you want, I can give you branches to test now, Andrew, or would you
> prefer to just wait for thirdparty RC to use for testing?
>
> On 3/16/18 5:46 PM, Andrew Purtell wrote:
>
>> +1 on protobuf. Any chance we can get a vote period long enough to do a
>> comparison perf / GC test? I can help.
>>
>> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>>
>> Probably too risky to do at this stage in the game but protobuf? We're on
>>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And
>>> Guava
>>> is 24.1 now. We're on 22.
>>>
>>> St.Ack
>>> 1. https://github.com/google/protobuf/releases
>>>
>>>
>>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>>
>>> Give a shout if there's anything that you all think would be good to
>>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>>
>>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>>> /browse/HBASE-20201.
>>>>
>>>> If there's more that should come in, please let me know!
>>>>
>>>>
>>>
>>
>>
>>
--
Best regards,
Andrew
Words like orphans lost among the crosstalk, meaning torn from truth's
decrepit hands
- A23, Crosstalk
Re: Looking at an hbase-thirdparty release
Posted by Josh Elser <el...@apache.org>.
Ran a quick test locally after update and things appear to be in the
same ballpark.
If you want, I can give you branches to test now, Andrew, or would you
prefer to just wait for thirdparty RC to use for testing?
On 3/16/18 5:46 PM, Andrew Purtell wrote:
> +1 on protobuf. Any chance we can get a vote period long enough to do a
> comparison perf / GC test? I can help.
>
> On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
>
>> Probably too risky to do at this stage in the game but protobuf? We're on
>> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And Guava
>> is 24.1 now. We're on 22.
>>
>> St.Ack
>> 1. https://github.com/google/protobuf/releases
>>
>>
>> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>>
>>> Give a shout if there's anything that you all think would be good to
>>> include in a new hbase-thirdparty release for HBase 2.0.
>>>
>>> I'm pulling in commons-cli as per https://issues.apache.org/jira
>>> /browse/HBASE-20201.
>>>
>>> If there's more that should come in, please let me know!
>>>
>>
>
>
>
Re: Looking at an hbase-thirdparty release
Posted by Andrew Purtell <ap...@apache.org>.
+1 on protobuf. Any chance we can get a vote period long enough to do a
comparison perf / GC test? I can help.
On Fri, Mar 16, 2018 at 2:41 PM, Stack <st...@duboce.net> wrote:
> Probably too risky to do at this stage in the game but protobuf? We're on
> 3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And Guava
> is 24.1 now. We're on 22.
>
> St.Ack
> 1. https://github.com/google/protobuf/releases
>
>
> On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
>
> > Give a shout if there's anything that you all think would be good to
> > include in a new hbase-thirdparty release for HBase 2.0.
> >
> > I'm pulling in commons-cli as per https://issues.apache.org/jira
> > /browse/HBASE-20201.
> >
> > If there's more that should come in, please let me know!
> >
>
--
Best regards,
Andrew
Words like orphans lost among the crosstalk, meaning torn from truth's
decrepit hands
- A23, Crosstalk
Re: Looking at an hbase-thirdparty release
Posted by Stack <st...@duboce.net>.
Probably too risky to do at this stage in the game but protobuf? We're on
3.3.1. Latest is 3.5.1 [1]: "Various performance optimizations." And Guava
is 24.1 now. We're on 22.
St.Ack
1. https://github.com/google/protobuf/releases
On Fri, Mar 16, 2018 at 1:47 PM, Josh Elser <el...@apache.org> wrote:
> Give a shout if there's anything that you all think would be good to
> include in a new hbase-thirdparty release for HBase 2.0.
>
> I'm pulling in commons-cli as per https://issues.apache.org/jira
> /browse/HBASE-20201.
>
> If there's more that should come in, please let me know!
>