You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/07/22 19:02:59 UTC

[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-docs/pull/298

    CB-9398: Added documentation for WindowsToastCapable to the Windows 

    ...docs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-docs CB-9398

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #298
    
----
commit 448410e2621be66d92b45d79d6cac64fd60fec47
Author: Rob Paveza <ro...@microsoft.com>
Date:   2015-07-22T16:59:03Z

    CB-9398: Added documentation for WindowsToastCapable to the Windows 8
    central document

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/298#discussion_r35931879
  
    --- Diff: docs/en/edge/guide/platforms/win8/index.md ---
    @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies
     on cross-platform source code that routinely overwrites the
     platform-specific files used by the SDK. If you want to use the SDK to
     modify the project, use the lower-level shell tools as an alternative
    -to the CLI.
    \ No newline at end of file
    +to the CLI.
    +
    +## Supporting Toasts
    +
    +Windows requires an app manifest capability declaration in order to support 
    +toast notifications.  When using the `cordova-plugin-local-notifications` 
    --- End diff --
    
    Sure, if a plugin is allowed to modify config.xml, then yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-docs/pull/298


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/298#discussion_r35931710
  
    --- Diff: docs/en/edge/guide/platforms/win8/index.md ---
    @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies
     on cross-platform source code that routinely overwrites the
     platform-specific files used by the SDK. If you want to use the SDK to
     modify the project, use the lower-level shell tools as an alternative
    -to the CLI.
    \ No newline at end of file
    +to the CLI.
    +
    +## Supporting Toasts
    +
    +Windows requires an app manifest capability declaration in order to support 
    +toast notifications.  When using the `cordova-plugin-local-notifications` 
    --- End diff --
    
    Ideally, the plugin should do this addition as part of plugin.xml no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/298#discussion_r35281287
  
    --- Diff: docs/en/edge/guide/platforms/win8/index.md ---
    @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies
     on cross-platform source code that routinely overwrites the
     platform-specific files used by the SDK. If you want to use the SDK to
     modify the project, use the lower-level shell tools as an alternative
    -to the CLI.
    \ No newline at end of file
    +to the CLI.
    +
    +## Supporting Toasts
    +
    +Windows requires an app manifest capability declaration in order to support 
    +toast notifications.  When using the `cordova-plugin-local-notifications` 
    --- End diff --
    
    I thought a plugin could add preferences 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/298#discussion_r35933864
  
    --- Diff: docs/en/edge/guide/platforms/win8/index.md ---
    @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies
     on cross-platform source code that routinely overwrites the
     platform-specific files used by the SDK. If you want to use the SDK to
     modify the project, use the lower-level shell tools as an alternative
    -to the CLI.
    \ No newline at end of file
    +to the CLI.
    +
    +## Supporting Toasts
    +
    +Windows requires an app manifest capability declaration in order to support 
    +toast notifications.  When using the `cordova-plugin-local-notifications` 
    --- End diff --
    
    Yes, it is allowed to add preferences.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org