[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #11708: add SQLServer grammar create database

[GitBox <gi...@apache.org>]

jingshanglu commented on a change in pull request #11708:
URL: https://github.com/apache/shardingsphere/pull/11708#discussion_r688184504



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/DDLStatement.g4
##########
@@ -450,3 +454,50 @@ onHistoryTableClause
 ifExist
     : IF EXISTS
     ;
+
+createDatabaseClause
+    : (CONTAINMENT EQ_ (NONE | PARTIAL))? fileDefinitionClause? (COLLATE ignoredIdentifier)? (WITH databaseOption (COMMA_ databaseOption)*)?
+    ;
+
+fileDefinitionClause
+    : ON PRIMARY? fileSpec (COMMA_ fileSpec)* (COMMA_ databaseFileGroup)* databaseLogOns
+    ;
+
+databaseOption
+    : FILESTREAM fileStreamOption (COMMA_ fileStreamOption)*
+    | DEFAULT_FULLTEXT_LANGUAGE = ignoredIdentifier
+    | DEFAULT_LANGUAGE = ignoredIdentifier
+    | NESTED_TRIGGERS = ( OFF | ON )
+    | TRANSFORM_NOISE_WORDS = ( OFF | ON )
+    | TWO_DIGIT_YEAR_CUTOFF = ignoredIdentifier
+    | DB_CHAINING ( OFF | ON )
+    | TRUSTWORTHY ( OFF | ON )
+    | PERSISTENT_LOG_BUFFER=ON ( DIRECTORY_NAME=ignoredIdentifier )
+    ;
+
+fileStreamOption
+    : NON_TRANSACTED_ACCESS EQ_ ( OFF | READ_ONLY | FULL )
+    | DIRECTORY_NAME = ignoredIdentifier
+    ;
+
+fileSpec
+    : LP_ NAME EQ_ ignoredIdentifier COMMA_ FILENAME EQ_ STRING_ databaseFileSpecOption RP_
+    ;
+
+databaseFileSpecOption
+    : (COMMA_ SIZE EQ_ numberLiterals (KB | MB | GB | TB)?)?
+    (COMMA_ MAXSIZE EQ_ (numberLiterals (KB | MB | GB | TB)? | UNLIMITED))?
+    (COMMA_ FILEGROWTH EQ_ numberLiterals (KB | MB | GB | TB | MOD_)?)?
+    ;
+
+databaseFileGroup
+    : FILEGROUP ignoredIdentifier databaseFileGroupContains? fileSpec (COMMA_ fileSpec)*
+    ;
+
+databaseFileGroupContains
+    : (CONTAINS FILESTREAM)? DEFAULT? | CONTAINS MEMORY_OPTIMIZED_DATA
+    ;
+
+databaseLogOns
+    : (LOG ON fileSpec (COMMA_ fileSpec)*)?
+    ;

Review comment:
       @Icesource There should be a empty line at the end of file.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/SQLServerKeyword.g4
##########
@@ -1070,3 +1066,72 @@ FILTER_COLUMN
 RETENTION_PERIOD
     : R E T E N T I O N UL_ P E R I O D
     ;
+
+CONTAINMENT
+    : C O N T A I N M E N T
+    ;
+
+PARTIAL
+    : P A R T I A L
+    ;
+
+FILENAME
+    : F I L E N A M E
+    ;
+
+SIZE
+    : S I Z E
+    ;
+
+MAXSIZE
+    : M A X S I Z E
+    ;
+
+FILEGROWTH
+    : F I L E G R O W T H
+    ;
+
+UNLIMITED
+    : U N L I M I T E D
+    ;
+
+KB
+    : K B
+    ;
+
+MB
+    : M B
+    ;
+
+GB
+    : G B
+    ;
+
+TB
+    : T B
+    ;
+
+CONTAINS
+    : C O N T A I N S
+    ;
+
+MEMORY_OPTIMIZED_DATA
+    : M E M O R Y UL_ O P T I M I Z E D UL_ D A T A
+    ;
+
+FILEGROUP
+    : F I L E G R O U P
+    ;
+
+NON_TRANSACTED_ACCESS
+    : N O N UL_ T R A N S A C T E D UL_ A C C E S S
+    ;
+
+DB_CHAINING
+    : D B UL_ C H A I N I N G
+    ;
+
+TRUSTWORTHY
+    : T R U S T W O R T H Y
+    ;
+

Review comment:
       @Icesource  If these tokens is not reserved keyword, maybe these should be contained in `unreservedWord `(BaseRule.g4).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org