You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2008/01/22 21:26:34 UTC
[jira] Created: (MATH-179) Fraction tests for double Constructor
Fraction tests for double Constructor
-------------------------------------
Key: MATH-179
URL: https://issues.apache.org/jira/browse/MATH-179
Project: Commons Math
Issue Type: Test
Reporter: Niall Pemberton
Priority: Minor
I was looking at borrowing some code from Fraction and the constructor that takes a double doesn't seem to have much tests. Attaching a patch - if I've missed something or these tests are a waste of time or its covered well elsewhere then please ignore this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MATH-179) Fraction tests for double Constructor
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luc Maisonobe resolved MATH-179.
--------------------------------
Resolution: Fixed
applied patch, thanks!
New tests are always welcome. I have also added a test that triggers an exception, using the well known golden ratio which is a kind of extreme irrational number.
> Fraction tests for double Constructor
> -------------------------------------
>
> Key: MATH-179
> URL: https://issues.apache.org/jira/browse/MATH-179
> Project: Commons Math
> Issue Type: Test
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: MATH-FractionConstructorDouble.patch
>
>
> I was looking at borrowing some code from Fraction and the constructor that takes a double doesn't seem to have much tests. Attaching a patch - if I've missed something or these tests are a waste of time or its covered well elsewhere then please ignore this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MATH-179) Fraction tests for double Constructor
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated MATH-179:
---------------------------------
Attachment: MATH-FractionConstructorDouble.patch
P.S. The m2 build seems to be broken btw (m1 works fine) I'll try to see why
> Fraction tests for double Constructor
> -------------------------------------
>
> Key: MATH-179
> URL: https://issues.apache.org/jira/browse/MATH-179
> Project: Commons Math
> Issue Type: Test
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: MATH-FractionConstructorDouble.patch
>
>
> I was looking at borrowing some code from Fraction and the constructor that takes a double doesn't seem to have much tests. Attaching a patch - if I've missed something or these tests are a waste of time or its covered well elsewhere then please ignore this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-179) Fraction tests for double Constructor
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561452#action_12561452 ]
Niall Pemberton commented on MATH-179:
--------------------------------------
Sorry ignore the m2 comment, must have been a one-off glitch - re-running works fine
> Fraction tests for double Constructor
> -------------------------------------
>
> Key: MATH-179
> URL: https://issues.apache.org/jira/browse/MATH-179
> Project: Commons Math
> Issue Type: Test
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: MATH-FractionConstructorDouble.patch
>
>
> I was looking at borrowing some code from Fraction and the constructor that takes a double doesn't seem to have much tests. Attaching a patch - if I've missed something or these tests are a waste of time or its covered well elsewhere then please ignore this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.