[jira] [Commented] (KYLIN-1948) IntegerDimEnc, does not encode -1 correctly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507796#comment-16507796 ] 

ASF GitHub Bot commented on KYLIN-1948:
---------------------------------------

tttMelody opened a new pull request #153: KYLIN-1948, add test to cover the case.
URL: https://github.com/apache/kylin/pull/153
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> IntegerDimEnc, does not encode -1 correctly
> -------------------------------------------
>
>                 Key: KYLIN-1948
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1948
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: liyang
>            Assignee: jiatao.tao
>            Priority: Major
>             Fix For: v2.4.0
>
>
> The code for -1 is all 0xff, which is the code for NULL. Need a fix, since -1 is a common value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)