[GitHub] [airflow] alexkruc commented on pull request #25280: Adding support for owner links in the Dags view UI

[GitBox <gi...@apache.org>]

alexkruc commented on PR #25280:
URL: https://github.com/apache/airflow/pull/25280#issuecomment-1201032219

   I have still 2 failing tests that I need help with, I wrapped my head around them for a long time and I'll appreciate some help and another pair of eyes :( 
   
   * `tests/serialization/test_dag_serialization.py - test_dag_serialization_to_timetable`
   I've added the new attributes that I've added to the tasks dict (owner_link), but the diff in the assert is mentioning much more differences, each `__type` is prefixed with` <Encoding.TYPE:` and `__var` with `<Encoding.VAR:` which I can't understand where it's coming from.
   
   * `tests/www/views/test_views_acl.py - test_dag_autocomplete_success`
   For some reason, the endpoint dagmodel/autocomplete for query `?query=flow` returns multiple owner fields. It's a bit strange for me, as the endpoint is calling `DagModel.owners` which is unchanged. The purpose of my PR is not to change the model of the current owners in the DB, and introduce all attributes in a new table. I can't figure out why now the endpoint in view.py is multiplying it.. One theory I have is that another failed test is not cleaning up it's DAG's in the DB after failure, and we are resulting with a stale DB state, that fails this one as we don't start from empty.. But I can't verify it :( 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org