You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ponymail.apache.org by se...@apache.org on 2020/08/17 10:53:37 UTC

[incubator-ponymail] branch master updated: Comment re broken code

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ponymail.git


The following commit(s) were added to refs/heads/master by this push:
     new 52d071f  Comment re broken code
52d071f is described below

commit 52d071f144faa2bf3d4b9f0adb83b36ebffc329f
Author: Sebb <se...@apache.org>
AuthorDate: Mon Aug 17 11:53:25 2020 +0100

    Comment re broken code
---
 tools/archiver.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/archiver.py b/tools/archiver.py
index 1f9e255..dfd5b26 100755
--- a/tools/archiver.py
+++ b/tools/archiver.py
@@ -332,7 +332,11 @@ class Archiver(object): # N.B. Also used by import-mbox.py
         body = self.msgbody(msg, verbose=args.verbose, ignore_body=args.ibody)
         try:
             if 'content-type' in msg_metadata and msg_metadata['content-type'].find("flowed") != -1:
+                # N.B. the convertToWrapped call always fails, because body is a string instead of bytes
                 body = formatflowed.convertToWrapped(body, character_set="utf-8")
+                # DO NOT FIX IT -- otherwise generated MIDs will change
+                # If it is desired to activate flow-formatting, it can be done after MID generation
+                # N.B. This code cannot just be moved intact as it transforms all input
             if isinstance(body, str):
                 body = body.encode('utf-8')
         except Exception: