You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/05 16:43:15 UTC

[GitHub] ptrendx commented on a change in pull request #14066: Add dtype visualization to plot_network

ptrendx commented on a change in pull request #14066: Add dtype visualization to plot_network
URL: https://github.com/apache/incubator-mxnet/pull/14066#discussion_r253947539
 
 

 ##########
 File path: python/mxnet/visualization.py
 ##########
 @@ -274,11 +278,19 @@ def plot_network(symbol, title="plot", save_format='pdf', shape=None, node_attrs
     draw_shape = False
     if shape is not None:
 
 Review comment:
   I agree with Chai - I can see usecase where you want to see shapes but don't have to put any shape information (so `shape={}`), which would return false if changed to `if shape`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services