You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/18 09:07:49 UTC

[GitHub] [airflow] kaxil commented on a diff in pull request #26436: Rename schema to database in PostgresHook

kaxil commented on code in PR #26436:
URL: https://github.com/apache/airflow/pull/26436#discussion_r973686981


##########
airflow/providers/postgres/hooks/postgres.py:
##########
@@ -95,7 +100,7 @@ def get_conn(self) -> connection:
             host=conn.host,
             user=conn.login,
             password=conn.password,
-            dbname=self.schema or conn.schema,
+            dbname=self.database or conn.schema,

Review Comment:
   Do we still want to set `dbanem` from `conn.schema`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org