You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/27 02:44:17 UTC

[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #622: [MNG-7129] Necessary changes on 3.x to support maven caching

AlexanderAshitkin commented on a change in pull request #622:
URL: https://github.com/apache/maven/pull/622#discussion_r757573479



##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -76,6 +78,9 @@
     @Requirement
     private ExecutionEventCatapult eventCatapult;
 
+    @Requirement
+    private MojosExecutionStrategy mojosExecutionStrategy;

Review comment:
       Small heads up here - we tried similar change and discovered that in maven 3 default strategy is not replaced even in presence of extension. So in runtime cache might not work even when CI passes succesfully




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org