You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/08 06:53:42 UTC
[GitHub] [fineract] nemux opened a new pull request #828: * Added changes to allow run -Penv=dev (see FINERACT-730)
nemux opened a new pull request #828:
URL: https://github.com/apache/fineract/pull/828
## Description
Based on https://issues.apache.org/jira/browse/FINERACT-730 and with the guide in https://mifosforge.jira.com/wiki/spaces/MDZ/pages/93093944/IntelliJ+IDEA+Setup
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #828: * Added changes to allow run -Penv=dev (see FINERACT-730)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #828:
URL: https://github.com/apache/fineract/pull/828#issuecomment-625747497
@nemux Thank You for this!! I'm ecstatic to see interest in (my) good old MariaDB4j... :smiling_face_with_three_hearts: But I think it's fair to say that maintaining the originally copy/pasted `dev-dependencies.gradle` has been a paint point for this project, over time. To illustrate the point I'm making, note that this will already break with #829 from @ptuomola ... I was wondering whether perhaps I could motivate you to use the opportunity of this PR to do what I just wrote up in FINERACT-939, and (finally!) just completely ditch `dev-dependencies.gradle` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org