You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "szaszm (via GitHub)" <gi...@apache.org> on 2023/04/12 07:05:30 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1553: MINIFICPP-2094 Change validators from shared to raw pointers

szaszm commented on code in PR #1553:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1553#discussion_r1163707467


##########
extensions/libarchive/BinFilesStaticDefinitions.cpp:
##########
@@ -34,19 +34,19 @@ const core::Property BinFiles::MinSize(
 const core::Property BinFiles::MaxSize(
     core::PropertyBuilder::createProperty("Maximum Group Size")
     ->withDescription("The maximum size for the bundle. If not specified, there is no maximum.")
-    ->withType(core::StandardValidators::get().UNSIGNED_LONG_VALIDATOR)->build());
+    ->withType(gsl::make_not_null(&core::StandardValidators::UNSIGNED_LONG_VALIDATOR))->build());

Review Comment:
   I think it would make more sense to have the builder functions take a const ref to the validators, instead of a not_null pointer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org