[GitHub] [zookeeper] ruanwenjun commented on a change in pull request #1759: ZOOKEEPER-4381: Remove magic string in QuorumPeerConfig

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #1759:
URL: https://github.com/apache/zookeeper/pull/1759#discussion_r732662808



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
##########
@@ -539,7 +592,8 @@ public void write(OutputStream output) throws IOException {
     /**
      * Writes dynamic configuration file
      */
-    public static void writeDynamicConfig(final String dynamicConfigFilename, final QuorumVerifier qv, final boolean needKeepVersion) throws IOException {
+    public static void writeDynamicConfig(final String dynamicConfigFilename, final QuorumVerifier qv,
+                                          final boolean needKeepVersion) throws IOException {

Review comment:
       Thanks for your review, I have reverted the uncorrelated changes, I am not sure if this will make the code style check failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org