You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Martonka (Code Review)" <ge...@cloudera.org> on 2025/07/17 14:58:21 UTC
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23182
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
CDPD-64590 Add a new metric to count received RPC calls
In clusters with a lot of tablets, there's often a great number of
consensus calls sent even without user activity. All of the tablets have
separate heartbeat timers, so each heartbeat RPC ends up causing a
wakeup and context switch on the server side.
We should explore ways of coalescing these RPCs. For experimenting with
batching heartbeats together, we need a metric to measure if the number
of received RPC messages decreases. We should have a metric counting all
types of RPC messages, so we can also see how much the number of RPC
calls decreases on a cluster with user activity too.
Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
---
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/tserver/tablet_server-test.cc
3 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/23182/1
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23182/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23182/1//COMMIT_MSG@7
PS1, Line 7: CDPD-64590
Please use upstream Apache JIRA items in the upstream Kudu development.
http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc
File src/kudu/rpc/service_pool.cc:
http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc@71
PS1, Line 71: METRIC_DEFINE_counter(server, rpcs_call_count,
: "RPC Calls received",
: kudu::MetricUnit::kRequests,
: "Number of RPCs calls received.",
I might be missing something, but I don't think this metric is really needed since the total number of accepted RPC calls can already be tracked by the 'total_count' of the 'rpc_incoming_queue_time' server-level histogram metric: https://kudu.apache.org/docs/metrics_reference.html#kudu-master_rpc_incoming_queue_time
At least per the description of this changelist, 'rpc_incoming_queue_time.total_count' should be enough for the use-cases mentioned there.
http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc@75
PS1, Line 75: kWarn
Even if introducing this metric, its severity level shouldn't be higher than kInfo priority, but I think of kDebug as the right one.
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jul 2025 17:44:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1579/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jul 2025 15:48:56 +0000
Gerrit-HasComments: No
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has abandoned this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward (763)
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1579/
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jul 2025 14:58:30 +0000
Gerrit-HasComments: No
[kudu-CR] CDPD-64590 Add a new metric to count received RPC calls
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (763) has posted comments on this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls
......................................................................
Patch Set 1:
rpc_incoming_queue_time.total_count
should be fine.
--
To view, visit http://gerrit.cloudera.org:8080/23182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85
Gerrit-Change-Number: 23182
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward (763)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jul 2025 06:42:09 +0000
Gerrit-HasComments: No