You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Stanislaw Osinski (JIRA)" <ji...@apache.org> on 2012/05/20 13:51:40 UTC

[jira] [Created] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Stanislaw Osinski created SOLR-3470:
---------------------------------------

             Summary: Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
                 Key: SOLR-3470
                 URL: https://issues.apache.org/jira/browse/SOLR-3470
             Project: Solr
          Issue Type: Bug
          Components: contrib - Clustering
    Affects Versions: 3.6
            Reporter: Stanislaw Osinski
            Assignee: Stanislaw Osinski
            Priority: Minor
             Fix For: 3.6.1




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated SOLR-3470:
------------------------------

    Attachment: SOLR-3470.patch

Here's my take at solving this. I temporarily substitute the context class loader to be the one from solr's resource loader (core).

This works (or seems to work) just fine. I don't particularly like it but I also don't want to mess with Solr's resource loaders if we don't have to.

I also piggyback a few cleanups.
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>         Attachments: SOLR-3470.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Stanislaw Osinski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanislaw Osinski resolved SOLR-3470.
-------------------------------------

    Resolution: Fixed

Fixed in trunk and 3.6.1 branch.
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Stanislaw Osinski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanislaw Osinski resolved SOLR-3470.
-------------------------------------

    Resolution: Fixed

Dawid's patch committed to trunk and 3.6 branch.
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>         Attachments: SOLR-3470.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss reassigned SOLR-3470:
---------------------------------

    Assignee: Stanislaw Osinski  (was: Dawid Weiss)

Review and let me know what you think. 
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>         Attachments: SOLR-3470.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Reopened] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Stanislaw Osinski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanislaw Osinski reopened SOLR-3470:
-------------------------------------


Unit tests pass fine, but Carrot2's internal class resolution code (context class loader) doesn't play well with how Solr loads contrib classes in webapp mode.

A brute-force fix would be to do the class loading the Solr way in the clustering component and pass class objects instead of strings to Carrot2.
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Stanislaw Osinski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanislaw Osinski updated SOLR-3470:
------------------------------------

    Fix Version/s: 4.0
    
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss reassigned SOLR-3470:
---------------------------------

    Assignee: Dawid Weiss  (was: Stanislaw Osinski)
    
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3470) Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

Posted by "Stanislaw Osinski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280023#comment-13280023 ] 

Stanislaw Osinski commented on SOLR-3470:
-----------------------------------------

Not pretty indeed, but still better than hardcoding Carrot2 attribute names. I'll commit this in a moment.
                
> Custom Carrot2 tokenizer and stemmer factories overwritten by defaults
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3470
>                 URL: https://issues.apache.org/jira/browse/SOLR-3470
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - Clustering
>    Affects Versions: 3.6
>            Reporter: Stanislaw Osinski
>            Assignee: Stanislaw Osinski
>            Priority: Minor
>             Fix For: 4.0, 3.6.1
>
>         Attachments: SOLR-3470.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org