You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/16 17:37:38 UTC
[GitHub] [arrow-datafusion] WinkerDu opened a new pull request, #2249: `-` operator support `NULL` constants
WinkerDu opened a new pull request, #2249:
URL: https://github.com/apache/arrow-datafusion/pull/2249
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1192 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Reproducer:
```
> select -null;
Internal("(- 'Literal { value: Utf8(NULL) }') can't be evaluated because the expression's type is Utf8, not signed numeric")
```
The result comes out `NULL` with this pr
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- `NegativeExpr` accepts `NULL` input then return `ScalarValue::Int32(None)` as `NULL`
- do `is_signed_numeric` type check when `NegativeExpr` evaluates
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] WinkerDu commented on pull request #2249: `-` operator support `NULL` constants
Posted by GitBox <gi...@apache.org>.
WinkerDu commented on PR #2249:
URL: https://github.com/apache/arrow-datafusion/pull/2249#issuecomment-1100733023
@alamb @xudong963 plz have a review, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] WinkerDu closed pull request #2249: `-` operator support `NULL` constants
Posted by GitBox <gi...@apache.org>.
WinkerDu closed pull request #2249: `-` operator support `NULL` constants
URL: https://github.com/apache/arrow-datafusion/pull/2249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #2249: `-` operator support `NULL` constants
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on PR #2249:
URL: https://github.com/apache/arrow-datafusion/pull/2249#issuecomment-1100831646
My opinion for this feature or new dialect https://github.com/apache/arrow-datafusion/issues/1192#issuecomment-1100830964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] WinkerDu commented on pull request #2249: `-` operator support `NULL` constants
Posted by GitBox <gi...@apache.org>.
WinkerDu commented on PR #2249:
URL: https://github.com/apache/arrow-datafusion/pull/2249#issuecomment-1100836593
Close this pr since more conservative opinions of introducing -NULL SQL dialect, see #1192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org