You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/15 07:50:44 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #8267: Support limits the max namespaces per tenant
315157973 opened a new pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267
Fixes #8224
### Motivation
Support limits the max namespaces per tenant of the Pulsar cluster. When the namespaces reach the max namespaces of the tenant, the broker should reject the new namespace request.
### Modifications
Add maxNamespacePerTenant=0 in the broker.conf and don't limit by default.
### Verifying this change
AdminApiTest2#testMaxNamespacePerTenant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-710091217
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-709856430
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#discussion_r506252402
##########
File path: conf/broker.conf
##########
@@ -201,6 +201,10 @@ brokerDeduplicationProducerInactivityTimeoutMinutes=360
# value will be used as the default
defaultNumberOfNamespaceBundles=4
+# The maximum number of namespaces that each tenant can create
+# This configuration is not precise control, in a concurrent scenario, the threshold will be exceeded
+maxNamespacePerTenant=0
Review comment:
```suggestion
maxNamespacesPerTenant=0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-710092494
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-709224756
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-710060135
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#discussion_r506252841
##########
File path: conf/broker.conf
##########
@@ -201,6 +201,10 @@ brokerDeduplicationProducerInactivityTimeoutMinutes=360
# value will be used as the default
defaultNumberOfNamespaceBundles=4
+# The maximum number of namespaces that each tenant can create
+# This configuration is not precise control, in a concurrent scenario, the threshold will be exceeded
+maxNamespacePerTenant=0
Review comment:
Please check all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-709302786
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #8267: Support limits the max namespaces per tenant
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #8267:
URL: https://github.com/apache/pulsar/pull/8267#issuecomment-710068106
docs should be updated because the broker.config file is updated. So i add a doc-required label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org