You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/10 20:48:04 UTC
[GitHub] [kafka] cadonna commented on a change in pull request #9583: MINOR: Make state stores not readable by others
cadonna commented on a change in pull request #9583:
URL: https://github.com/apache/kafka/pull/9583#discussion_r520860033
##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##########
@@ -106,6 +110,27 @@ public void shouldCreateBaseDirectory() {
assertTrue(appDir.isDirectory());
}
+ @Test
+ public void shouldHaveSecurePermissions() {
+ final Set<PosixFilePermission> expectedPermissions = EnumSet.of(
+ PosixFilePermission.OWNER_EXECUTE,
+ PosixFilePermission.GROUP_READ,
+ PosixFilePermission.OWNER_WRITE,
+ PosixFilePermission.GROUP_EXECUTE,
+ PosixFilePermission.OWNER_READ);
+
+ final Path statePath = Paths.get(stateDir.getPath());
+ final Path basePath = Paths.get(appDir.getPath());
+ try {
+ final Set<PosixFilePermission> baseFilePermissions = Files.getPosixFilePermissions(statePath);
+ final Set<PosixFilePermission> appFilePermissions = Files.getPosixFilePermissions(basePath);
+ assertEquals(expectedPermissions, baseFilePermissions);
+ assertEquals(expectedPermissions, appFilePermissions);
Review comment:
Recently, we prefer to use `assertThat()` instead of `assertEquals()`.
##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##########
@@ -106,6 +110,27 @@ public void shouldCreateBaseDirectory() {
assertTrue(appDir.isDirectory());
}
+ @Test
+ public void shouldHaveSecurePermissions() {
+ final Set<PosixFilePermission> expectedPermissions = EnumSet.of(
+ PosixFilePermission.OWNER_EXECUTE,
+ PosixFilePermission.GROUP_READ,
+ PosixFilePermission.OWNER_WRITE,
+ PosixFilePermission.GROUP_EXECUTE,
+ PosixFilePermission.OWNER_READ);
+
+ final Path statePath = Paths.get(stateDir.getPath());
+ final Path basePath = Paths.get(appDir.getPath());
+ try {
+ final Set<PosixFilePermission> baseFilePermissions = Files.getPosixFilePermissions(statePath);
+ final Set<PosixFilePermission> appFilePermissions = Files.getPosixFilePermissions(basePath);
+ assertEquals(expectedPermissions, baseFilePermissions);
+ assertEquals(expectedPermissions, appFilePermissions);
+ } catch (final IOException e) {
+ // okay
Review comment:
If we swallow the exception here, and the test always throws an IO exception, we will never notice. I guess it would be better to use `fail()` with a message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org