[GitHub] [hbase] joshelser commented on a change in pull request #1207: HBASE-23892 KeyStoreTestUtil.getClasspathDir NPE when running UT exte…

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #1207: HBASE-23892 KeyStoreTestUtil.getClasspathDir NPE when running UT exte…
URL: https://github.com/apache/hbase/pull/1207#discussion_r385489082
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/SecureTestCluster.java
 ##########
 @@ -52,6 +52,12 @@
 
   private static String HTTP_PRINCIPAL;
 
+  //When extending SecureTestCluster on downstream projects that refer SecureTestCluster via
+  //hbase-server jar, we need to provide a way for the implementation to refer to its own class
+  //definition, so that KeyStoreTestUtil.getClasspathDir can resolve a valid path in the local FS
+  //to place required SSL config files.
+  protected static Class testRunner = SecureTestCluster.class;
 
 Review comment:
   Make a setter for this as a static method and you have my +1 :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services