[jira] [Commented] (CB-7284) Improve File plugin for windows platform compatibility with current API specs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092855#comment-14092855 ] 

ASF GitHub Bot commented on CB-7284:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/67

    CB-7284 Improve File plugin for windows platform compatibility with current API specs

    Fixes multiple spec tests errors (CB-7284)[https://issues.apache.org/jira/browse/CB-7284]:
    
    Full list of changes:
    
    FileProxy:
    * Adds removal of trailing slashes for incoming native paths since Windows threat them as illegal
    * Combine getMetadata and getFileMetadata into one method (this fixes multiple metadata spec tests)
    * Adds private routine for creating Filesystem instance for Entry from full path to Entry (getFilesystemFromPath)
    * Adds filesystem parameter specification for all constructed instances of Entry, FileEntry and DirectoryEntry classes
    * Fixes readAsBinaryString method to return true binary string instead of unicode string
    * Adds support for slicing to readAsBinaryString and readAsArrayBuffer methods
    * Fix removeRecursively method to disallow root directory removal
    * Remove multiple usages of createFileQuery and createFolderQuery which is unsupported on Windows Phone 8.1
    
    DirectoryEntry:
    * Adds additional check for nativeURL is not undefined/null in DirectoryEntry constructor
    
    Entry:
    * Update copyTo and MoveTo methods with proper usage of entry.filesystem in success callbacks (was entry.filesystemName earlier, but Entry class don't have filesystemName property)
    
    resolveLocalFileSystemURI:
    * Update resolveLocalFileSystemURL method with proper usage of entry.filesystem in success callbacks (was entry.filesystemName earlier, but Entry class don't have filesystemName property)
    * Adds additional check for leading slash in provided path at resolveLocalFileSystemURL method (since failure of file.spec.12 window.resolveLocalFileSystemURI should error (ENCODING_ERR) when resolving invalid URI with leading /.)
    
    
    This also includes fix for getMetadata method from https://github.com/apache/cordova-plugin-file/pull/56

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-7284

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
    
----
commit 0ffb96988c0539222887f7756a653e7f0a1ed12c
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-08-11T11:33:36Z

    Fixes multiple mobilespec tests errors

commit 700c3d8d8348a460640847303199025b4e1b6a25
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-08-11T12:56:06Z

    Adds Windows platform

----


> Improve File plugin for windows platform compatibility with current API specs
> -----------------------------------------------------------------------------
>
>                 Key: CB-7284
>                 URL: https://issues.apache.org/jira/browse/CB-7284
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>            Reporter: Vladimir Kotikov
>
> At this moment File plugin for Windows 8 contains multiple issues, so the great part of mobilespec's tests fails, and some of tests are crashing windows store application.
> Current list of failing specs consists of about of 70 entries. Most of them are failed by timeout due to various errors in callbacks, so this increase testing time heavily.



--
This message was sent by Atlassian JIRA
(v6.2#6252)