[GitHub] [inlong] vernedeng commented on a diff in pull request #6294: [INLONG-6288][Manager] Refactor getSortClusterConfig by using MyBatis Cursor

[GitBox <gi...@apache.org>]

vernedeng commented on code in PR #6294:
URL: https://github.com/apache/inlong/pull/6294#discussion_r1008997463


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/AbstractSinkOperator.java:
##########
@@ -213,6 +217,23 @@ public void deleteOpt(StreamSinkEntity entity, String operator) {
         sinkFieldMapper.logicDeleteAll(entity.getId());
     }
 
+    @Override
+    public Map<String, String> parse2IdParams(StreamSinkEntity streamSink, List<String> fields) {
+        Map<String, String> param;
+        try {
+            param = objectMapper.readValue(streamSink.getExtParams(), Map.class);
+        } catch (Exception e) {
+            LOGGER.error("cannot parse properties of groupId={}, streamId={}, sinkName={}, the row properties is={}, "
+                            + "exception={}", streamSink.getInlongGroupId(), streamSink.getInlongStreamId(),
+                    streamSink.getSinkName(), streamSink.getExtParams(), e.getMessage());
+            return null;

Review Comment:
   No, the error parsing will produce a **_null_** IdParams, which will be filtered to ensure correct config updating of other groupIds 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org