You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/04/28 03:58:04 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #25385: Refactor ShardingSphereMetaData, ShardingSphereDatabase and ShardingSphereSchema to avoid call inner map
strongduanmu opened a new issue, #25385:
URL: https://github.com/apache/shardingsphere/issues/25385
In issue #25349, I refactor ShardingSphereTable to avoid direct access to the internal map object by adding some public methods. Because the internal map object converts the key to lowercase in order to be case-compatible, and the external logic can not guarantee that all the operations are converted to lowercase after obtaining the map, so it will lead to some logical errors.
The same problem exists in ShardingSphereMetaData, ShardingSphereDatabase and ShardingSphereSchema, where we need to do some refactoring to avoid internal map objects being accessed.
- [ ] refactor ShardingSphereMetaData and call usage
- [ ] refactor ShardingSphereDatabase and call usage
- [ ] refactor ShardingSphereSchema and call usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #25385: Refactor ShardingSphereMetaData, ShardingSphereDatabase and ShardingSphereSchema to avoid call inner map
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #25385:
URL: https://github.com/apache/shardingsphere/issues/25385#issuecomment-1536942082
Hi @yangsen00, this task may not be suitable for beginners, you can try other good first issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yangsen00 commented on issue #25385: Refactor ShardingSphereMetaData, ShardingSphereDatabase and ShardingSphereSchema to avoid call inner map
Posted by "yangsen00 (via GitHub)" <gi...@apache.org>.
yangsen00 commented on issue #25385:
URL: https://github.com/apache/shardingsphere/issues/25385#issuecomment-1536112250
May I have a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org