You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "alisha-1000 (via GitHub)" <gi...@apache.org> on 2026/01/31 17:36:28 UTC

[PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

alisha-1000 opened a new pull request, #4142:
URL: https://github.com/apache/streampipes/pull/4142

   This PR adds support for inline `//` comments in the PLC4X S7 advanced code block configuration.
   
   Previously, comments placed at the end of a configuration line were treated as part of the PLC datatype, which caused parsing errors such as:
   `Datatype %DB1281:0:REAL // comment is not supported`.
   
   With this change, inline comments are stripped before parsing key/value pairs, while preserving support for full-line comments and existing configurations.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

Posted by "alisha-1000 (via GitHub)" <gi...@apache.org>.
alisha-1000 commented on PR #4142:
URL: https://github.com/apache/streampipes/pull/4142#issuecomment-3836372519

   Hi @tenthe,
   Thanks for the suggestion! I’ve added a unit test to cover inline `//` comments in ConfigurationParserTest.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #4142:
URL: https://github.com/apache/streampipes/pull/4142#issuecomment-3835245642

   Hi @alisha-1000,
   
   thanks a lot for this PR!
   This looks good to me.
   
   If you want, you could also add some unit tests for the new functionality in `ConfigurationParserTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #4142:
URL: https://github.com/apache/streampipes/pull/4142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

Posted by "alisha-1000 (via GitHub)" <gi...@apache.org>.
alisha-1000 commented on PR #4142:
URL: https://github.com/apache/streampipes/pull/4142#issuecomment-3841364342

   Hi @tenthe,
   
   Thanks for pointing that out.
   I’ve reverted the unintended UI-related commit, so this PR now only affects the PLC4X S7 inline comment parsing.
   
   Appreciate the review!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(plc4x-s7): support inline // comments in PLC4X S7 advanced configuration

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #4142:
URL: https://github.com/apache/streampipes/pull/4142#issuecomment-3840340260

   Hi @alisha-1000,
   
   somehow the changes from this PR #4147 ended up here.
   Can you please remove it so there will be no merge conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org