[GitHub] [airflow] ashb opened a new pull request, #23291: Revert "EdgeModifier refactoring (#21404)"

[GitBox <gi...@apache.org>]

ashb opened a new pull request, #23291:
URL: https://github.com/apache/airflow/pull/23291

   This reverts commit ace8c6e942ff5554639801468b971915b7c0e9b9.
   
   Fixes apache/airflow#23285
   
   This dag breaks with a cycle as group.end has itself as a downstream otherwise:
   
   ```python
   from pendulum import datetime
   
   from airflow.decorators import dag, task, task_group
   from airflow.utils.edgemodifier import Label
   
   @task
   def begin():
       ...
   
   @task
   def end():
       ...
   
   @dag(start_date=datetime(2022, 1, 1), schedule_interval=None)
   def task_groups_with_edge_labels():
       @task_group
       def group():
           begin() >> end()
   
       group()
   
   _ = task_groups_with_edge_labels()
   ```
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #23291: Revert "EdgeModifier refactoring (#21404)"

[GitBox <gi...@apache.org>]

ashb merged PR #23291:
URL: https://github.com/apache/airflow/pull/23291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23291: Revert "EdgeModifier refactoring (#21404)"

[GitBox <gi...@apache.org>]

github-actions[bot] commented on PR #23291:
URL: https://github.com/apache/airflow/pull/23291#issuecomment-1111301864

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org