You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/12/18 17:26:26 UTC
Review Request 54846: Removed `docker exec` when perform health
checks in docker executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gast�n Kleiman, and Lukas Loesche.
Bugs: MESOS-4812
https://issues.apache.org/jira/browse/MESOS-4812
Repository: mesos
Description
-------
After Mesos could specify namespaces to enter to perform health checks,
the command health check in docker executor doesn't need to wrap
command with `docker exec` anymore. Remove `docker exec` aslo fixes
the problem when escape quote character in command health checks.
Diffs
-----
src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/54846/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 54846: Removed `docker exec` when perform health
checks in docker executor.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/#review164683
-----------------------------------------------------------
src/docker/executor.cpp (line 486)
<https://reviews.apache.org/r/54846/#comment236449>
should we include the pid namespace as well, or is that implicit (or handled elsewhere)?
- James DeFelice
On Dec. 18, 2016, 5:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54846/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 5:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gast�n Kleiman, and Lukas Loesche.
>
>
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After Mesos could specify namespaces to enter to perform health checks,
> the command health check in docker executor doesn't need to wrap
> command with `docker exec` anymore. Remove `docker exec` aslo fixes
> the problem when escape quote character in command health checks.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
> src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
>
> Diff: https://reviews.apache.org/r/54846/diff/
>
>
> Testing
> -------
>
> Added new test cases `HealthCheckTest.ROOT_DOCKER_DockerEnvironmentSetup` and run
>
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*"
> [----------] Global test environment tear-down
> [==========] 22 tests from 1 test case ran. (75423 ms total)
> [ PASSED ] 22 tests.
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54846: Removed `docker exec` when perform health
checks in docker executor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/#review164759
-----------------------------------------------------------
Bad patch!
Reviews applied: [54846]
Failed command: python support/apply-reviews.py -n -r 54846
Error:
2017-02-08 20:14:44 URL:https://reviews.apache.org/r/54846/diff/raw/ [8551/8551] -> "54846.patch" [1]
error: patch failed: src/docker/executor.cpp:474
error: src/docker/executor.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17026/console
- Mesos Reviewbot
On Dec. 18, 2016, 5:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54846/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 5:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gast�n Kleiman, and Lukas Loesche.
>
>
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After Mesos could specify namespaces to enter to perform health checks,
> the command health check in docker executor doesn't need to wrap
> command with `docker exec` anymore. Remove `docker exec` aslo fixes
> the problem when escape quote character in command health checks.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
> src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
>
> Diff: https://reviews.apache.org/r/54846/diff/
>
>
> Testing
> -------
>
> Added new test cases `HealthCheckTest.ROOT_DOCKER_DockerEnvironmentSetup` and run
>
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*"
> [----------] Global test environment tear-down
> [==========] 22 tests from 1 test case ran. (75423 ms total)
> [ PASSED ] 22 tests.
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54846: Removed `docker exec` when perform health
checks in docker executor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/#review165493
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Dec. 18, 2016, 5:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54846/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 5:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gast�n Kleiman, and Lukas Loesche.
>
>
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After Mesos could specify namespaces to enter to perform health checks,
> the command health check in docker executor doesn't need to wrap
> command with `docker exec` anymore. Remove `docker exec` aslo fixes
> the problem when escape quote character in command health checks.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
> src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
>
> Diff: https://reviews.apache.org/r/54846/diff/
>
>
> Testing
> -------
>
> Added new test cases `HealthCheckTest.ROOT_DOCKER_DockerEnvironmentSetup` and run
>
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*"
> [----------] Global test environment tear-down
> [==========] 22 tests from 1 test case ran. (75423 ms total)
> [ PASSED ] 22 tests.
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54846: Removed `docker exec` when perform health
checks in docker executor.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 5:30 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gast�n Kleiman, and Lukas Loesche.
Bugs: MESOS-4812
https://issues.apache.org/jira/browse/MESOS-4812
Repository: mesos
Description
-------
After Mesos could specify namespaces to enter to perform health checks,
the command health check in docker executor doesn't need to wrap
command with `docker exec` anymore. Remove `docker exec` aslo fixes
the problem when escape quote character in command health checks.
Diffs (updated)
-----
src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/54846/diff/
Testing (updated)
-------
Added new test cases `HealthCheckTest.ROOT_DOCKER_DockerEnvironmentSetup` and run
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*"
[----------] Global test environment tear-down
[==========] 22 tests from 1 test case ran. (75423 ms total)
[ PASSED ] 22 tests.
```
Thanks,
haosdent huang