You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2021/08/25 08:05:24 UTC

[lucene] 09/12: Fix gradle error hints.

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git

commit 0cbafa48795dcf21dc625ac9c2561e754d437ff0
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Tue Aug 24 13:46:50 2021 +0200

    Fix gradle error hints.
---
 gradle/generation/javacc.gradle | 2 ++
 gradle/generation/jflex.gradle  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/gradle/generation/javacc.gradle b/gradle/generation/javacc.gradle
index fc51dae..b639d01 100644
--- a/gradle/generation/javacc.gradle
+++ b/gradle/generation/javacc.gradle
@@ -269,6 +269,8 @@ class JavaCCTask extends DefaultTask {
    * Apply closures to all generated files before they're copied back
    * to mainline code.
    */
+  // A subtle bug here is that this makes it not an input... should be a list of replacements instead?
+  @Internal
   List<Closure<FileTree>> afterGenerate = new ArrayList<>()
 
   @OutputFiles
diff --git a/gradle/generation/jflex.gradle b/gradle/generation/jflex.gradle
index aa60d7f..02e8da9 100644
--- a/gradle/generation/jflex.gradle
+++ b/gradle/generation/jflex.gradle
@@ -222,7 +222,7 @@ class JFlexTask extends DefaultTask {
   @InputFile
   File skeleton
 
-  @Optional
+  @Internal
   String heapSize
 
   @OutputFile