You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2010/06/04 11:04:55 UTC
[jira] Commented: (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875534#action_12875534 ]
Jacques Le Roux commented on OFBIZ-2628:
----------------------------------------
I was looking at this issue by chance (actually 1st in most important list) and trying to associate DVD+R a parent rollup I got this error
ERROR: Could not complete the Add ProductCategory to Category [file:/home/ofbiz/trunk/applications/product/script/org/ofbiz/product/category/CategoryServices.xml#addProductCategoryToCategory] process [problem creating the newEntity value: Error while inserting: [GenericEntity:ProductCategoryRollup][createdStamp,2010-06-04 10:01:45.461(java.sql.Timestamp)][createdTxStamp,2010-06-04 10:01:45.439(java.sql.Timestamp)][fromDate,2010-06-04 11:00:40.44(java.sql.Timestamp)][lastUpdatedStamp,2010-06-04 10:01:45.461(java.sql.Timestamp)][lastUpdatedTxStamp,2010-06-04 10:01:45.439(java.sql.Timestamp)][parentProductCategoryId,CATALOG1(java.lang.String)][productCategoryId,DVD R(java.lang.String)] (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT_CATEGORY_ROLLUP (PRODUCT_CATEGORY_ID, PARENT_PRODUCT_CATEGORY_ID, FROM_DATE, THRU_DATE, SEQUENCE_NUM, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'PRODUCT_CATEGORY_ROLLUP' caused a violation of foreign key constraint 'PROD_CRLP_CURRENT' for key (DVD R). The statement has been rolled back.))]
Patrick, do you think you will continue to work on this, have you solved it?
Thanks
> No Url encoding for get parameters
> ----------------------------------
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
> Environment: All
> Reporter: Patrick Antivackis
> Priority: Critical
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is DVD+R
> Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side effects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.