You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/22 23:34:47 UTC

[GitHub] zheng-da commented on a change in pull request #12157: Subgraph API for integrating accelerators with MXNet

zheng-da commented on a change in pull request #12157: Subgraph API for integrating accelerators with MXNet
URL: https://github.com/apache/incubator-mxnet/pull/12157#discussion_r212135476
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -436,7 +436,8 @@ inline void PushFComputeEx(const FComputeEx& fn,
       }
     };
 
-  if (exec_type == ExecType::kCrossDeviceCopy) {
+  if (exec_type == ExecType::kCrossDeviceCopy
+      || exec_type == ExecType::kSubgraphExec) {
 
 Review comment:
   we don't need kSubgraphExec here. kSubgraphExec only works for stateful operators.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services