[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7149: Traffic Dump: Record HTTP/2 priority.

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on a change in pull request #7149:
URL: https://github.com/apache/trafficserver/pull/7149#discussion_r485816194



##########
File path: plugins/experimental/traffic_dump/session_data.cc
##########
@@ -69,6 +69,12 @@ std::unordered_map<std::string, std::string> tag_to_node = {
   {std::string(IP_PROTO_TAG_HTTP_3), R"("name":"http","version":"3")"},
 };
 
+std::unordered_map<std::string, std::string> http_tag_to_version = {
+  {std::string(IP_PROTO_TAG_HTTP_0_9), "0.9"},  {std::string(IP_PROTO_TAG_HTTP_1_0), "1.0"},

Review comment:
       Why make the key a `std::string`? All of the keys are literals so `std::string_view` would work as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org