[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1998: [KYUUBI #1962] Make create SparkSession as Future

[GitBox <gi...@apache.org>]

wForget commented on a change in pull request #1998:
URL: https://github.com/apache/incubator-kyuubi/pull/1998#discussion_r823567411



##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/KyuubiFunSuite.scala
##########
@@ -134,6 +134,23 @@ trait KyuubiFunSuite extends AnyFunSuite
     }
   }
 
+  final def withSystemProperty(properties: Map[String, String])(f: => Unit): Unit = {
+    val originValues = properties.map {
+      case (key, value) =>
+        val originValue = System.getProperty(value)

Review comment:
       > `System.getProperty(value)` value? do you mean key?
   
   yeah, i wiil fix it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org