You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/01 05:24:52 UTC
[GitHub] [couchdb] jiangphcn opened a new pull request #3118: Allow to continue to cleanup search index even if there is invalid design document
jiangphcn opened a new pull request #3118:
URL: https://github.com/apache/couchdb/pull/3118
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
In some situation where design document for search index created by customer is not valid, the _search_cleanup endpoint will stop to clean up. This will leave some search index orphan. The change is to allow to continue to clean up search index even if there is invalid design document for search.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
make elixir tests=src/dreyfus/test/elixir/test/search_test.exs
```
SearchTest
* test clean up search index with invalid design document (55.1ms)
ReshardHelpers
PartitionHelpers
Finished in 0.07 seconds
1 test, 0 failures
```
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [X] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiangphcn commented on pull request #3118: Allow to continue to cleanup search index even if there is invalid design document
Posted by GitBox <gi...@apache.org>.
jiangphcn commented on pull request #3118:
URL: https://github.com/apache/couchdb/pull/3118#issuecomment-684622645
thanks @garrensmith for review and thanks @wohali for sharing the chance to put this into 3.x. I just merged change https://github.com/apache/couchdb/pull/3119 to 3.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3118: Allow to continue to cleanup search index even if there is invalid design document
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3118:
URL: https://github.com/apache/couchdb/pull/3118#issuecomment-684514617
When this is ready, please backport to `3.x`.
This will be the last change before I cut CouchDB 3.1.1, if it makes it in today or tomorrow 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiangphcn merged pull request #3118: Allow to continue to cleanup search index even if there is invalid design document
Posted by GitBox <gi...@apache.org>.
jiangphcn merged pull request #3118:
URL: https://github.com/apache/couchdb/pull/3118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org