You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2021/08/29 15:56:29 UTC
[groovy] branch GROOVY_3_0_X updated: Trivial refactoring for
`JavaStubCompilationUnit.hasAcceptedFileExtension`
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/GROOVY_3_0_X by this push:
new 59b616a Trivial refactoring for `JavaStubCompilationUnit.hasAcceptedFileExtension`
59b616a is described below
commit 59b616a6e2e7c3580ab7c5d38b9356d0bc47ca6d
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sun Aug 29 23:12:49 2021 +0800
Trivial refactoring for `JavaStubCompilationUnit.hasAcceptedFileExtension`
(cherry picked from commit 66596d28f7874a3c9e4fc2726d72f82aed83a7c9)
---
.../org/codehaus/groovy/tools/javac/JavaStubCompilationUnit.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/tools/javac/JavaStubCompilationUnit.java b/src/main/java/org/codehaus/groovy/tools/javac/JavaStubCompilationUnit.java
index 46e1d42..89af49f 100644
--- a/src/main/java/org/codehaus/groovy/tools/javac/JavaStubCompilationUnit.java
+++ b/src/main/java/org/codehaus/groovy/tools/javac/JavaStubCompilationUnit.java
@@ -111,10 +111,7 @@ public class JavaStubCompilationUnit extends CompilationUnit {
private boolean hasAcceptedFileExtension(String name) {
String lowerCasedName = name.toLowerCase();
- for (String extension : configuration.getScriptExtensions()) {
- if (lowerCasedName.endsWith(extension))
- return true;
- }
- return false;
+ String extension = lowerCasedName.substring(lowerCasedName.lastIndexOf('.') + 1);
+ return configuration.getScriptExtensions().contains(extension);
}
}